Fix errors when running with python 2.7.14#3
Open
AzP wants to merge 1 commit intoRaySearchLabsPublic:masterfrom
Open
Fix errors when running with python 2.7.14#3AzP wants to merge 1 commit intoRaySearchLabsPublic:masterfrom
AzP wants to merge 1 commit intoRaySearchLabsPublic:masterfrom
Conversation
ryanneph
suggested changes
Dec 14, 2017
There was a problem hiding this comment.
@AzP I would be more inclined to replace the tests for "None" with if <obj> is None: since the current test will fail if the object is indeed None (since .all() is not a method defined on None types). Take a look at my commit for the changes. I'm not aware of any way to directly suggest the changes into this PR.
Author
|
@ryanneph I agree that your fix(es) are better, could you open a PR for your commit as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If updating Anaconda, the script fails with warnings about "ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()"
There might be a better way of fixing this, I wasn't sure about calling .any on None.