Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 88.86% 88.84% -0.02%
==========================================
Files 7 7
Lines 548 556 +8
==========================================
+ Hits 487 494 +7
- Misses 61 62 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Ofc this breaks compatibility with all previous python versions. Suggestions welcome as I don't have a lot of time and are quite new to building packages for pip |
methane
reviewed
Feb 3, 2026
| connector = os.path.join( | ||
| os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C" | ||
| os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C", | ||
| os.environ["ProgramFiles"], "MariaDB", "MariaDB Connector C 64-bit", |
Member
There was a problem hiding this comment.
I don't have Windows box now. Is this current default location of official installer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested changes to fix deprecation and changes to format of project.license in python 3.14: C:\Users\XXX\AppData\Local\Temp\pip-build-env-cc_fwjqb\overlay\Lib\site-packages\setuptools\config_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning:
project.licenseas a TOML table is deprecated!!
And also to fix build errors when using the 64 bit MariaDB Connector C, but not sure if this is the correct way.