Repository navigation
Conversation
emnpiex
changed the title
- this brings the schemas in line with the documentation
emnpiex
force-pushed
the
fix/int-schema-size-not-in-array
branch
from
April 30, 2026 13:24
7328f94 to
8ab5673
Compare
emnpiex
changed the title
This was referenced Oct 3, 2026
rom1504
reviewed
Oct 3, 2026
rom1504
left a comment
rom1504
left a comment
Member
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
At 8ab5673, this looks ready for maintainer merge review. Both int and lint now accept the documented parameter object shape, such as ["int", {"size": 3}], instead of requiring an extra array around it. The required size and rejection of additional properties remain intact.
Keep the separate bounds proposal in #63 as its own decision. This is a scoped schema/documentation comparison, not a fresh all-codec test run.
Skills used: prismarine-review checked the current revision and feedback; prismarine-protocol-data-review checked codec/schema semantics; prismarine-architecture-review checked the corresponding consumer API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this brings the "numeric" schemas in line with the documentation. the schemas appear to require an extraneous object-nesting.
is validated by old schema.
is validated by new schema.