Conversation
Add support for Angular httpResource. The support is added only for GET request as adviced by Angular docs: ``` TIP: Avoid using httpResource for mutations like POST or PUT. Instead, prefer directly using the underlying HttpClient APIs. ``` non-GET methods still rely on rxjs.
gonzalad
force-pushed
the
feature/angular-http-resource
branch
from
December 12, 2025 15:00
9659bab to
f3e3dd7
Compare
…seSingleRequestParameter=true
|
Hello, Thanks |
Member
|
please resolve the merge conflicts in this PR or open a new PR based on this one instead. thank you |
aggroman
approved these changes
Aug 19, 2026
aggroman
suggested changes
Aug 19, 2026
| useValue: new Configuration({ ...configOrBasePath }), | ||
| }, | ||
| ]); | ||
| } No newline at end of file |
Comment on lines
+40
to
+47
| /** | ||
| * Add a new pet to the store | ||
| * @endpoint post /pet | ||
| * @param body Pet object that needs to be added to the store | ||
| * @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body. | ||
| * @param reportProgress flag to report request and response progress. | ||
| * @param options additional options | ||
| */ |
There was a problem hiding this comment.
indent seem like not to be proper generated
| let localVarHeaders = this.defaultHeaders; | ||
|
|
||
| // authentication (petstore_auth) required | ||
| localVarHeaders = this.configuration.addCredentialToHeaders('petstore_auth', 'Authorization', localVarHeaders, 'Bearer '); |
aggroman
suggested changes
Aug 19, 2026
| } | ||
| ); | ||
| } | ||
| {{#useHttpResource}} |
There was a problem hiding this comment.
is it intended to ignore observable option for GET requests, when useHttpResource === true?
if so, then developers would not have an option to keep previous implementations as they are and forced to use httpResource everywhere. my proposal would be to allow both, when useHttpResource is available.
return httpResource when input is provided as Signal, otherwise Observable
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Angular’s experimental httpResource API (see issue #21263).
Support is currently limited to GET requests, following Angular’s official recommendation:
All non-GET methods continue to rely on RxJS.
Tests
A new integration test was introduced:
TypescriptAngularResourceIntegrationTest.
As with the other TypeScript integration tests, it is currently disabled in the pushed version.
Generated API (example)
Parameters accept either signal or non-signal types, enabling flexible usage depending on the consumer’s needs.
Single GET example:
List GET example:
Cheers,
Adrian
N.B. This PR targets typescript, so I mention the technical comitee @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)