Implements global user config - #63
Merged
Merged
Conversation
MiniCodeMonkey
force-pushed
the
global-config
branch
from
September 28, 2026 05:05
5ba92bd to
0813308
Compare
Owner
|
Thanks for this. I rebased it on the updated #62 and pushed two fixes to your branch.
One open question for later: the global file is |
Author
|
LGTM! Same goes for #62 |
…_HOME. Merge global config with project specific (if any)
Load decodes the user file and then the project file into one Config. yaml.v3 only overwrites fields whose keys are present, so a project key wins even when it is false or empty (e.g. opting out of a global onComplete.push: true), and new config fields need no merge code. SaveValue sets a single dotted key in the project file and leaves the rest of the file alone, so keys a project never set keep inheriting. Claude-Session: https://claude.ai/code/session_01Fxi8Py1Weyua51Y1RBt2NP
Settings saved the whole effective config, which now includes values inherited from the user config. Toggling one setting in a project copied every inherited global value into .chief/config.yaml and pinned it there. Settings now writes only the edited key via config.SaveValue. Claude-Session: https://claude.ai/code/session_01Fxi8Py1Weyua51Y1RBt2NP
MiniCodeMonkey
force-pushed
the
global-config
branch
from
September 28, 2026 10:14
0813308 to
841cb59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some parts of the code depends on #62 being merged