Update icons and tooltip in test explorer indicating status of test files/suites #4583

Activity

1. ghost added

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   on Feb 27, 2019
2. Dan Taylor (qubitron)

   added

   needs proposalNeed to make some design decisionsNeed to make some design decisions

   needs PR

   area-testing

   and removed

   triage-neededNeeds assignment to the proper sub-teamNeeds assignment to the proper sub-team

   needs proposalNeed to make some design decisionsNeed to make some design decisions

   on Feb 27, 2019
3. Don Jayamanne (DonJayamanne)

   added

   needs proposalNeed to make some design decisionsNeed to make some design decisions

   on Feb 27, 2019
4. DonJayamanne commented on Feb 27, 2019

   

   Don Jayamanne (DonJayamanne)

   on Feb 27, 2019

   Last edited by DonJayamanne

   More actions

   • When tests have not run what's the icon against the file, folder, suite, function?
     • Green check mark for all successful tests
     • If any test fails, then parent fails
     • When status = Idle or Unknown, then display a "Not Run" icon
     • Similarly, tooltips would be a summary of all child nodes
   • What happens when a test is skipped?
     • Display not run icon
5. Don Jayamanne (DonJayamanne)

   changed the title [-]Show icons in test explorer indicating status of test files/suites[/-] [+]Update icons and tooltip in test explorer indicating status of test files/suites[/+] on Feb 27, 2019
6. DonJayamanne commented on Feb 27, 2019

   

   Don Jayamanne (DonJayamanne)

   on Feb 27, 2019

   Last edited by DonJayamanne

   More actions

   File to modify:

   • src/client/unittests/explorer/testTreeViewItem.ts
   • Create new tooltip getter to provide tooltip based on data
   • Existing iconPath getter to provide icon based on data
7. qubitron commented on Feb 27, 2019

   

   Dan Taylor (qubitron)

   on Feb 27, 2019

   Author

   More actions

   Don Jayamanne (@DonJayamanne) we should have a "not run" icon that is the same across all levels, if a test is skipped (how?) then it would be the same as not running it.
8. Brett Cannon (brettcannon)

   added this to the 2019, week 9 - Feb Sprint 5 milestone on Feb 28, 2019
9. Brett Cannon (brettcannon)

   assigned

   Kartik Raj (karrtikr)

   on Feb 28, 2019
10. Don Jayamanne (DonJayamanne)

    added

    feature-requestRequest for new features or functionalityRequest for new features or functionality

    and removed

    needs proposalNeed to make some design decisionsNeed to make some design decisions

    on Feb 28, 2019
11. Don Jayamanne (DonJayamanne)

    self-assigned this

    on Mar 11, 2019
12. DonJayamanne commented on Mar 12, 2019

    

    Don Jayamanne (DonJayamanne)

    on Mar 12, 2019

    More actions

    Kartik Raj (@karrtikr) Please check #4727
13. Don Jayamanne (DonJayamanne)

    added a commit that references this issue on Mar 13, 2019

    Icon should be unknown when no tests are run (#4710)

    ...

    1cc6f39
14. Don Jayamanne (DonJayamanne)

    modified the milestones: 2019, week 9 - Feb Sprint 5, 2019, week 11 - March Sprint 6 on Mar 13, 2019
15. DonJayamanne commented on Mar 13, 2019

    

    Don Jayamanne (DonJayamanne)

    on Mar 13, 2019

    More actions

    Issues identified during demo:

    • Tooltips for folders and files do not work
      • We display the text nan instead of the number
    • Doesn't work with failed or all passed tests
    • Round the number of seconds to 2 decimal places.
16. Don Jayamanne (DonJayamanne)

    closed this as completedon Mar 18, 2019
17. ghost removed

    needs PR

    on Mar 18, 2019
18. lock

    locked as resolved and limited conversation to collaborators on Apr 15, 2019