fix: allow signer thumbnail access and prefer file_id preview URLs#7539
fix: allow signer thumbnail access and prefer file_id preview URLs#7539vitormattos merged 15 commits intomainfrom
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
8845a02 to
2b6924e
Compare
|
/backport to stable33 |
|
/backport to stable32 |
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
… thumbnail tests Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…l access PDF preview is unavailable in the CI environment (no ghostscript/imagick), so getPreview() throws NotFoundException → 404. Using mimeFallback=1 makes the controller fall back to the PDF mime icon redirect (303), which is always available in any Nextcloud installation. Non-signer tests remain asserting 403, which the RequireFileAccess middleware returns before the controller body executes. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/7539/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f85c0e07 e8366a37 a5bb60ef 473e9bc9 a9b46aa7 2b6924e7 aae65949 964ac855 669d47cb 2907f6a6 abb8b477 21d10fc8 1a97e737 6635d3af 0d4d3d93
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7539/stable32Error: Failed to push branch backport/7539/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/7539/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f85c0e07 e8366a37 a5bb60ef 473e9bc9 a9b46aa7 2b6924e7 aae65949 964ac855 669d47cb 2907f6a6 abb8b477 21d10fc8 1a97e737 6635d3af 0d4d3d93
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7539/stable33Error: Failed to push branch backport/7539/stable33: To https://github.com/LibreSign/libresign.git Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Problem
Signers with access to a document could not always load its thumbnail in LibreSign.
What changed
file_idthumbnail endpoint, withnodeIdas fallback.Close #7537