Skip to content

fix(readers): throw asyncapiexception, as this is handled by the main reader. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisualBean merged 2 commits into from
Nov 28, 2022
Merged

fix(readers): throw asyncapiexception, as this is handled by the main reader. #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a7b56
use correct exception which are handled
VisualBean Nov 28, 2022
31da16b
missed channel binding
VisualBean Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/LEGO.AsyncAPI.Readers/V2/AsyncApiChannelBindingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace LEGO.AsyncAPI.Readers
{
using LEGO.AsyncAPI.Exceptions;
using LEGO.AsyncAPI.Models;
using LEGO.AsyncAPI.Models.Bindings;
using LEGO.AsyncAPI.Models.Interfaces;
Expand Down Expand Up @@ -45,7 +46,7 @@ internal static IChannelBinding LoadChannelBinding(ParseNode node)
case BindingType.Websockets:
return LoadBinding("ChannelBinding", property.Value, webSocketsChannelBindingFixedFields);
default:
throw new System.Exception("ChannelBinding not found");
throw new AsyncApiException($"ChannelBinding {property.Name} is not supported");
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/LEGO.AsyncAPI.Readers/V2/AsyncApiMessageBindingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace LEGO.AsyncAPI.Readers
{
using LEGO.AsyncAPI.Exceptions;
using LEGO.AsyncAPI.Extensions;
using LEGO.AsyncAPI.Models;
using LEGO.AsyncAPI.Models.Bindings;
Expand Down Expand Up @@ -48,7 +49,7 @@ internal static IMessageBinding LoadMessageBinding(ParseNode node)
case BindingType.Http:
return LoadBinding<HttpMessageBinding>("MessageBinding", property.Value, httpMessageBindingFixedFields);
default:
throw new System.Exception("MessageBinding not found");
throw new AsyncApiException($"MessageBinding {property.Name} is not supported");
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/LEGO.AsyncAPI.Readers/V2/AsyncApiOperationBindingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace LEGO.AsyncAPI.Readers
{
using LEGO.AsyncAPI.Exceptions;
using LEGO.AsyncAPI.Models;
using LEGO.AsyncAPI.Models.Bindings;
using LEGO.AsyncAPI.Models.Interfaces;
Expand Down Expand Up @@ -45,7 +46,7 @@ internal static IOperationBinding LoadOperationBinding(ParseNode node)
case BindingType.Http:
return LoadBinding("OperationBinding", property.Value, httpOperationBindingFixedFields);
default:
throw new System.Exception("OperationBinding not found");
throw new AsyncApiException($"OperationBinding {property.Name} is not supported");
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/LEGO.AsyncAPI.Readers/V2/AsyncApiServerBindingDeserializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace LEGO.AsyncAPI.Readers
{
using LEGO.AsyncAPI.Exceptions;
using LEGO.AsyncAPI.Models;
using LEGO.AsyncAPI.Models.Bindings;
using LEGO.AsyncAPI.Models.Interfaces;
Expand Down Expand Up @@ -43,7 +44,7 @@ internal static IServerBinding LoadServerBinding(ParseNode node)
case BindingType.Kafka:
return LoadBinding("ServerBinding", property.Value, kafkaServerBindingFixedFields);
default:
throw new System.Exception("ServerBinding not found");
throw new AsyncApiException($"ServerBinding {property.Name} is not supported");
}
}
}
Expand Down