fix: make optional properties of bindings nullable#89
Merged
VisualBean merged 25 commits intomainfrom Mar 1, 2023
Merged
Conversation
![github-actions[bot]](/s/com/githubusercontent/avatars/G.https/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you ullebe1 for your first pull request to AsyncAPI.NET repository. Please check out our contributors guide.
VisualBean
reviewed
Feb 8, 2023
VisualBean
reviewed
Feb 8, 2023
VisualBean
reviewed
Feb 8, 2023
VisualBean
reviewed
Feb 8, 2023
VisualBean
reviewed
Feb 8, 2023
src/LEGO.AsyncAPI/Models/Bindings/Pulsar/PulsarChannelBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 8, 2023
src/LEGO.AsyncAPI/Models/Bindings/Pulsar/PulsarChannelBinding.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
added
asyncapi.tests
documentation
ullebe1
force-pushed
the
ullebe1/optionals_nullable
branch
from
b01e212 to
80e7258
Compare
github-actions
bot
removed
asyncapi.tests
documentation
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/Kafka/KafkaOperationBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/Kafka/KafkaOperationBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/Kafka/TopicConfigurationObject.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/Pulsar/PulsarServerBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/WebSockets/WebSocketsChannelBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
src/LEGO.AsyncAPI/Models/Bindings/WebSockets/WebSocketsChannelBinding.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Feb 24, 2023
VisualBean
reviewed
Feb 24, 2023
Contributor
Author
|
Reverted the commit putting the versions in quotes in strings. Seems there is something inconsistent in how that works. On my machine they need to be in quotes for the tests to pass, in CI they cannot be in quotes or the tests fail. No special setup, just running |
VisualBean
reviewed
Feb 28, 2023
test/LEGO.AsyncAPI.Tests/Bindings/Pulsar/PulsarBindings_Should.cs
Outdated
Show resolved
Hide resolved
VisualBean
approved these changes
Feb 28, 2023
… ullebe1/optionals_nullable
VisualBean
approved these changes
Feb 28, 2023
Contributor
|
This change will be a part of the 3.0 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes all properties of bindings that are optional nullable, so as to make them optional in the library as well.