feat: add cultureinfo to reader/writer settings.#152
Merged
VisualBean merged 15 commits intoLEGO:mainfrom Mar 30, 2024
Merged
Conversation
Added culture info to date time parsing and writing
Contributor
Author
|
As per usual feel free to push back on anything you don't agree with :) |
ByronMayne
commented
Mar 25, 2024
ByronMayne
commented
Mar 25, 2024
ByronMayne
commented
Mar 25, 2024
VisualBean
reviewed
Mar 25, 2024
VisualBean
reviewed
Mar 25, 2024
VisualBean
reviewed
Mar 25, 2024
VisualBean
reviewed
Mar 25, 2024
VisualBean
reviewed
Mar 26, 2024
test/LEGO.AsyncAPI.Tests/Serialization/SpecialCharacterStringExtensionsTests.cs
Outdated
Show resolved
Hide resolved
ByronMayne
commented
Mar 26, 2024
ByronMayne
commented
Mar 26, 2024
VisualBean
reviewed
Mar 27, 2024
src/LEGO.AsyncAPI.Readers/Exceptions/AsyncApiUnsupportedSpecVersionException.cs
Outdated
Show resolved
Hide resolved
VisualBean
reviewed
Mar 27, 2024
VisualBean
reviewed
Mar 28, 2024
VisualBean
reviewed
Mar 30, 2024
Contributor
VisualBean
left a comment
There was a problem hiding this comment.
Only a few things, but otherwise I am happy with it
Co-authored-by: Alex Wichmann <VisualBean@users.noreply.github.com>
Contributor
|
Definitely not against splitting unit tests apart. |
VisualBean
reviewed
Mar 30, 2024
Contributor
|
Thanks a ton @ByronMayne, great addition to the project. |
VisualBean
approved these changes
Mar 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
The unit tests are currently failing to run on linux but work on windows due to differences with date time parsing and newlines. In this PR I have done the following
Changelog
Follow up questions
JsonHelper,YamlConverter, and previouslyStringExtensions. Would it make sense to combine them into either theConfigurationin this review or have them as an instance that is passed around as a context?