feat(bindings): add SQS AWS Bindings#113
Conversation
Co-authored-by: UlrikSandberg <UJSandberg@gmail.com>
Co-authored-by: Goker Akce <goker.akce@justeattakeaway.com> Co-authored-by: Alex Wichmann <VisualBean@users.noreply.github.com>
|
Hi @VisualBean, Sorry for posting on this PR, it seemed a bit formal to create an issue but I can convert this comment into that if required. I wanted to move onto start using the custom binding functionality on some internal bindings, but it seems that the LEGO.AsyncAPI.Bindings package hasn't been released to Nuget yet. And the main package hasn't been released in a while either. Do you have anything against doing a release? As it seems like there have been substantial changes since the last release, or is there something specific you're waiting for? (Totally fine if so, just want to be aware of the time line). |
|
I wanted your new bindings in, before making a 4.0 release. I have a working example of the extensions thing we talked about, so it's definitely possible. I am currently house-renovating why my answers and code pushes hasbeen sparse. I'll push my extension changes this evening and we can get that change into your PR's and THEN i can push a V4 for you |
|
@VisualBean Thanks for the update. Absolutely no pressure dude! I’m not blocked. For the moment I’m just referencing a local version of the library until the new Nuget package is ready. Good luck with the house renovations! 🙏 |
to be able to set during initialization, a setter was added to the Bindings property.
Co-authored-by: Dec Kolakowski <51292634+dpwdec@users.noreply.github.com>
refactor: updated StringOrStringList class
|
Hi @VisualBean, I think this PR is now matching the state described in the AsyncAPI bindings repo, so I'm happy to proceed to merge. Let me know if there's any further clean up etc. Also, I'm not sure how to fill out the changelog and issues section so would appreciate some guidance here. Once it is merged I will move forward with SNS. |
VisualBean
changed the title
…feat-add-sqs-aws-bindings
github-actions
bot
removed
the
documentation
chore: Added more unit tests
|
@VisualBean I think I've addressed your above comments now.
|
|
@VisualBean tests should be fixed now, I think integrating main I messed up some merges. |
VisualBean
changed the title
|
Great work @dpwdec, thanks for keeping at it! |
3 participants
About the PR
Add SQS bindings
Changelog
StringOrStringListtypeRelated Issues
None