Speed-up character data loading#19
Merged
Kronuz merged 1 commit intoKronuz:masterfrom Jan 26, 2022
SeaHOH:patch-1
Merged
Conversation
Contributor
Author
|
https://github.com/jquery/esprima/blob/512cd66c6ffd6083144b0150f09670e426252776/src/character.ts Max-unicode in above script is 0xFFDC. |
In Python 3, sys.maxunicode is 0x10FFFF, this caused slow loading, and in fact it is not necessary in our code. And clear some unused data to save memory use.
Owner
|
Awesome finding! Thank you for working on this. |
Contributor
Author
|
Can you release a new version as soon? I think this is a bit major. |
SeaHOH
added a commit
to SeaHOH/esprima-python
that referenced
this pull request
Feb 5, 2022
xet7
pushed a commit
to wekan/wekan
that referenced
this pull request
Oct 25, 2022
Sigh, python-esprima is really not well maintained: - the maintainer merged Kronuz/esprima-python#19 - this breaks entirely his project - the submitter of PR 19 submitted a fix one week later - 10 months later, the fix is still not merged :( Pull it locally so we get our docs building again. Fixes: #4731
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3, sys.maxunicode is 0x10FFFF, this caused slow loading, and in fact it is not necessary in our code.
And clear some unused data to save memory use.