Repository navigation
Use the SpectrumInput widget for the adjustment node Properties panel layouts - #4105
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the node graph properties UI by introducing spectrum sliders for several raster adjustment nodes, including Levels, Hue/Saturation, and Black & White. It refactors the SpectrumInput widget to support a compact 'narrow' mode, renames 'swap' functionality to 'reorder', and adds double-click support for resetting markers. A potential division-by-zero issue was identified in the spectrum_slider_row helper function when calculating marker positions if the value range is zero.
5 of 51 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of these nodes have been updated from number range sliders to color spectrum slider inputs for visual intuition: