Skip to content

deps(memorystore): update dependencies across redis samples - #4484

Merged
angelcaamal merged 3 commits into
mainfrom
deps-update-memorystore-redis-samples
Sep 28, 2026
Merged

angelcaamal merged 3 commits into
mainfrom
deps-update-memorystore-redis-samples

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes b/565777861
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: memorystore labels Sep 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum Node.js engine requirement to version 20.0.0 across the Redis packages and upgrades several dependencies, including @opentelemetry/resources and chai. However, upgrading chai to ^6.0.0 introduces a breaking change because Chai v5 and above are ESM-only, which is incompatible with this project's CommonJS configuration. It is recommended to revert chai to ^4.3.0 to prevent test failures.

Comment thread memorystore/redis/client_side_metrics/package.json

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcolin
amcolin marked this pull request as ready for review September 28, 2026 19:34
@amcolin
amcolin requested review from a team as code owners September 28, 2026 19:34

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal
angelcaamal merged commit 2e6e19f into main Sep 28, 2026
23 checks passed
@angelcaamal
angelcaamal deleted the deps-update-memorystore-redis-samples branch September 28, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: memorystore samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants