Skip to content

chore(video-intelligence): update package dependencies - #4422

Draft
angelcaamal wants to merge 2 commits into
mainfrom
chore/update-video-intelligence-samples-package
Draft

angelcaamal wants to merge 2 commits into
mainfrom
chore/update-video-intelligence-samples-package

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/553467107

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: videointelligence Issues related to the Video Intelligence API API. samples Issues that are directly related to samples. labels Aug 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0 and upgrades several dependencies in video-intelligence/package.json, including @google-cloud/video-intelligence, c8, and chai. Feedback was provided to revert the chai upgrade to ^4.5.0, as upgrading to v6.0.0 will cause test failures due to ESM-only compatibility issues in a CommonJS project.

"c8": "^10.0.0",
"chai": "^4.5.0",
"c8": "^12.0.0",
"chai": "^6.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Chai v5.0.0 and above (including v6.0.0) are ESM-only. Since this project is configured as CommonJS (it lacks "type": "module" in package.json and uses require in its source files), upgrading to chai v6 will cause tests to fail with ERR_REQUIRE_ESM when trying to require chai. It is recommended to keep chai at ^4.5.0 unless the project is migrated to ESM.

Suggested change
"chai": "^6.0.0",
"chai": "^4.5.0",

@angelcaamal angelcaamal added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: videointelligence Issues related to the Video Intelligence API API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant