Skip to content

Update passphrase with the correct format;#16294

Merged
melinath merged 2 commits intoGoogleCloudPlatform:mainfrom
zhihaos:b/480770989
Feb 5, 2026
Merged

Update passphrase with the correct format;#16294
melinath merged 2 commits intoGoogleCloudPlatform:mainfrom
zhihaos:b/480770989

Conversation

@zhihaos
Copy link
Copy Markdown
Contributor

@zhihaos zhihaos commented Feb 4, 2026

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 39
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • ces

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCESApp_cesAppBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCESApp_cesAppBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 40
Passed tests: 39
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • ces

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCESApp_cesAppBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCESApp_cesAppBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zhihaos zhihaos marked this pull request as ready for review February 4, 2026 15:28
@github-actions github-actions Bot requested a review from melinath February 4, 2026 15:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Copy Markdown
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's some flakiness because of the IAM role provisioning, which could be addressed by switching to IAM bootstrapping: https://googlecloudplatform.github.io/magic-modules/test/test/#iam-resources

However, that's not a blocker for this PR. Thanks!

@melinath melinath added this pull request to the merge queue Feb 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit eb51acb Feb 5, 2026
26 checks passed
18811376770 pushed a commit to 18811376770/magic-modules that referenced this pull request Feb 11, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCESApp_cesAppBasicExample

3 participants