fix(bigqueryanalyticshub): rewrite updateMask for replica_locations in pre_update#16293
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 26 Click here to see the affected service packages
🟢 All tests passed! View the build log |
|
hey @BBBmau can you please look into this andmerge if everything looks ok? |
|
@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
BBBmau
left a comment
There was a problem hiding this comment.
it appears that we don't have test for when an update takes place in both data_affinity_regions and replica_locations. Can you look into including a simple TestAcc?
Rewrites the updateMask in the request URL to target the specific replicaLocations and dataAffinityRegions sub-fields rather than their parent objects
This is built on top of : #16156
and #16236