Skip to content

fix(bigqueryanalyticshub): rewrite updateMask for replica_locations in pre_update#16293

Merged
SirGitsalot merged 1 commit intoGoogleCloudPlatform:mainfrom
okvidhi:my-new-feature-branch
Feb 9, 2026
Merged

fix(bigqueryanalyticshub): rewrite updateMask for replica_locations in pre_update#16293
SirGitsalot merged 1 commit intoGoogleCloudPlatform:mainfrom
okvidhi:my-new-feature-branch

Conversation

@okvidhi
Copy link
Copy Markdown
Contributor

@okvidhi okvidhi commented Feb 4, 2026

Rewrites the updateMask in the request URL to target the specific replicaLocations and dataAffinityRegions sub-fields rather than their parent objects

This is built on top of : #16156
and #16236

bigqueryanalyticshub: fixed update failure for `replica_locations` in `google_bigquery_analytics_hub_listing` (beta)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 4, 2026
@github-actions github-actions Bot requested a review from BBBmau February 4, 2026 13:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/bigquery and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 4, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 20 insertions(+))
google-beta provider: Diff ( 1 file changed, 20 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 26
Passed tests: 26
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • bigqueryanalyticshub

🟢 All tests passed!

View the build log

@okvidhi
Copy link
Copy Markdown
Contributor Author

okvidhi commented Feb 5, 2026

hey @BBBmau can you please look into this andmerge if everything looks ok?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 9, 2026

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears that we don't have test for when an update takes place in both data_affinity_regions and replica_locations. Can you look into including a simple TestAcc?

@SirGitsalot SirGitsalot added this pull request to the merge queue Feb 9, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 9a4d89e Feb 9, 2026
31 checks passed
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Feb 24, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants