feat(discoveryengine): add action, BAP, and destination config support to google_discovery_engine_data_connector

[phillipweston]

Adds the missing API surface for Gemini Enterprise / Agentspace data connectors to google_discovery_engine_data_connector, enabling full configuration of action connectors, BAP settings, destination routing, and data source versioning.

New fields

action_config block

Configures action capabilities for connectors using the ACTIONS connector mode (e.g. Jira actions).

• action_params (map, write-only) — connection credentials and configuration (instance URI, client ID, client secret, auth type)
• is_action_configured (bool, computed) — whether the action connector is fully configured
• create_bap_connection (bool, write-only) — whether to create a BAP connection

bap_config block

Controls which actions are enabled for connectors using the ACTIONS connector mode.

• enabled_actions (list of strings) — actions to enable, e.g. create_issue, update_issue, change_issue_status, create_comment, update_comment, upload_attachment
• supported_connector_modes (list of strings) — connector modes for the BAP configuration, e.g. ACTIONS

destination_configs block

Configures where data is served for the connector.

• key (string) — destination config key, e.g. url
• destinations — list of destination objects, each with a host (string)

data_source_version (integer)

Specifies the version of the data source, e.g. 3 for Jira v3.

Example usage

resource "google_discovery_engine_data_connector" "jira" {
  location                = "global"
  collection_id           = "jira-collection"
  collection_display_name = "Jira Federated"
  data_source             = "jira"
  data_source_version     = 3

  params = {
    instance_uri  = "https://your-instance.atlassian.net"
    instance_id   = "projects/.../secrets/instance_id/versions/latest"
    client_id     = "projects/.../secrets/client_id/versions/latest"
    client_secret = "projects/.../secrets/client_secret/versions/latest"
    refresh_token = "projects/.../secrets/refresh_token/versions/latest"
    auth_type     = "OAUTH"
  }

  refresh_interval = "86400s"
  connector_modes  = ["FEDERATED", "ACTIONS"]

  entities { entity_name = "project" }
  entities { entity_name = "issue" }
  entities { entity_name = "comment" }
  entities { entity_name = "attachment" }

  destination_configs {
    key = "url"
    destinations {
      host = "https://your-instance.atlassian.net"
    }
  }

  action_config {
    action_params = {
      instance_uri  = "https://your-instance.atlassian.net"
      instance_id   = "projects/.../secrets/instance_id/versions/latest"
      client_id     = "projects/.../secrets/client_id/versions/latest"
      client_secret = "projects/.../secrets/client_secret/versions/latest"
      auth_type     = "OAUTH"
    }
    create_bap_connection = true
  }

  bap_config {
    supported_connector_modes = ["ACTIONS"]
    enabled_actions = [
      "create_issue",
      "update_issue",
      "change_issue_status",
      "create_comment",
      "update_comment",
      "upload_attachment",
    ]
  }
}

Changes

• mmv1/products/discoveryengine/DataConnector.yaml — added actionConfig, bapConfig, destinationConfigs, and dataSourceVersion property definitions
• mmv1/templates/terraform/examples/discoveryengine_dataconnector_jira_with_actions.tf.tmpl — new Jira example demonstrating all new fields
• mmv1/templates/terraform/state_migrations/discovery_engine_data_connector.go.tmpl — added new fields to v0 schema for state migration compatibility
• mmv1/third_party/terraform/services/discoveryengine/resource_discovery_engine_data_connector_test.go — updated acceptance tests with all new fields

discoveryengine: added `action_config`, `bap_config`, `destination_configs`, and `data_source_version` to `google_discovery_engine_data_connector` resource (beta)

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[phillipweston]

This PR is necessary in order to support Gemini Enterprise's new way of handling Actions (write operations). It is my first PR into this repository, so I'm open to any suggestions and willing to do whatever is necessary to get it over the finish line. Thank you!

This is the payload that the API expects:

{
  "collectionId": "jira-federated_1770130797837",
  "collectionDisplayName": "Jira Federated",
  "dataConnector": {
    "dataSource": "jira",
    "params": {
      "instance_uri": "https://your-instance.atlassian.net",
      "instance_id": "unused",
      "client_id": "unused",
      "client_secret": "unused",
      "refresh_token": "unused",
      "auth_type": "OAUTH"
    },
    "refreshInterval": "86400s",
    "incrementalSyncDisabled": true,
    "autoRunDisabled": true,
    "entities": [
      {
        "entityName": "project",
        "params": { "inclusion_filters": {}, "exclusion_filters": {} }
      },
      { "entityName": "attachment" },
      { "entityName": "comment" },
      { "entityName": "issue" },
      { "entityName": "bug" },
      { "entityName": "epic" },
      { "entityName": "story" },
      { "entityName": "task" },
      { "entityName": "worklog" },
      { "entityName": "board" }
    ],
    "dataSourceVersion": 3,
    "destinationConfigs": [
      {
        "key": "url",
        "destinations": [{ "host": "https://phillipweston.atlassian.net" }]
      }
    ],
    "staticIpEnabled": false,
    "actionConfig": {
      "actionParams": {
        "instance_uri": "https://phillipweston.atlassian.net",
        "client_id": "...",
        "client_secret": "...",
        "instance_id": "7d1727f0-e98f-4f00-97e5-743b24491dba",
        "auth_type": "OAUTH"
      },
      "createBapConnection": true,
      "isActionConfigured": true
    },
    "bapConfig": {
      "supportedConnectorModes": ["ACTIONS"],
      "enabledActions": [
        "create_issue",
        "update_issue",
        "change_issue_status",
        "create_comment",
        "update_comment",
        "upload_attachment"
      ]
    },
    "connectorModes": ["FEDERATED", "ACTIONS"]
  }
}

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 820 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 820 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 185 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 161 insertions(+))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages

• discoveryengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorJiraWithActionsExample
• TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorServicenowBasicExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorJiraWithActionsExample [Error message] [Debug log]
TestAccDiscoveryEngineDataConnector_discoveryengineDataconnectorServicenowBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[trodge]

Looks like you'll need to add update_time here.

[phillipweston]

Thank you!

[phillipweston]

@trodge Thank you. I've added it. Also, I can't view the ErrorMessage or DebugLog above, getting a 403 Forbidden, so hands feel a bit tied in helping debug these.

Does this repo require you to manually trigger the additional test suites each time?

[phillipweston]

@modular-magician /test

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[trodge]

/gcbrun

[trodge]

Test is still failing with

  error=
  | After applying this test step, the plan was not empty.
  | stdout:
  | 
  | 
  | Terraform used the selected providers to generate the following execution
  | plan. Resource actions are indicated with the following symbols:
  |   ~ update in-place
  | 
  | Terraform will perform the following actions:
  | 
  |   # google_discovery_engine_data_connector.servicenow-basic will be updated in-place
  |   ~ resource "google_discovery_engine_data_connector" "servicenow-basic" {
  |       - data_source_version             = 2 -> null
  |         id                              = "projects/ci-test-project-188019/locations/global/collections/tf-test-collection-id1fk4vo1ofk/dataConnector"
  |         name                            = "projects/1067888929963/locations/global/collections/tf-test-collection-id1fk4vo1ofk/dataConnector"
  |         # (24 unchanged attributes hidden)
  | 
  |       ~ entities {
  |           + key_property_mappings = {}
  |             # (3 unchanged attributes hidden)
  |         }
  |       ~ entities {
  |           + key_property_mappings = {}
  |             # (3 unchanged attributes hidden)
  |         }
  |       ~ entities {
  |           + key_property_mappings = {}
  |             # (3 unchanged attributes hidden)
  |         }
  |     }
  | 
  | Plan: 0 to add, 1 to change, 0 to destroy.

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[phillipweston]

/gcbrun

[phillipweston]

Thanks @trodge, I've updated the code to fix the latest issues in question.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 822 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 5 files changed, 822 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 185 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 161 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_data_connector (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_data_connector" "primary" {
  entities {
    key_property_mappings = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 38
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• discoveryengine

🟢 All tests passed!

View the build log

[phillipweston]

@trodge I've got all tests passing now, if you can please take a look. Thank you!

[phillipweston]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 822 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 5 files changed, 822 insertions(+), 5 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 185 insertions(+)) Open in Cloud Shell: Diff ( 4 files changed, 161 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_discovery_engine_data_connector (4 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_discovery_engine_data_connector" "primary" {
  entities {
    key_property_mappings = # value needed
  }
}

This has been addressed.

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 837 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 5 files changed, 837 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 185 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 161 insertions(+))

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 38
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• discoveryengine

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.