Add skip validations in vmware admin cluster

[naitianliu-google]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gkeonprem: added `skip_validations` field to `google_gkeonprem_vmware_admin_cluster` resource 

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 21 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 21 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gkeonprem_vmware_admin_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gkeonprem_vmware_admin_cluster" "primary" {
  skip_validations = # value needed
}

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 21
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages

• gkeonprem

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterBasicExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterFullExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterMetallbExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterBasicExample [Debug log]
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterFullExample [Debug log]
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterMetallbExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[slevenick]

I'll wait for tests to run again, but I'm not seeing the query param successfully populated in the previous run of the tests. Are you able to run these tests & see the query param actually be populated in the HTTP request? Is it possible to create a config that would fail to apply unless the skip validations parameter is successfully sent?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 23 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 23 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 21
Skipped tests: 1
Affected tests: 3

Click here to see the affected service packages

• gkeonprem

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterBasicExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterFullExample
• TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterMetallbExample

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 27 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 27 insertions(+), 5 deletions(-))

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterBasicExample [Debug log]
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterFullExample [Debug log]
TestAccGkeonpremVmwareAdminCluster_gkeonpremVmwareAdminClusterMetallbExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• gkeonprem

🟢 All tests passed!

View the build log

[github-actions]

@naitianliu-google, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@naitianliu-google, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@naitianliu-google, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@naitianliu-google, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@naitianliu-google, this PR is being closed due to inactivity.