Converted write_only_legacy fields to write_only

[melinath]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[wj-chen]

The Breaking Change report shows generated provider changes that don't quite match this config change, is that expected?

[melinath]

@wj-chen I'm not quite sure what doesn't match, but for context, this PR isn't actually intended to make the change - just to demonstrate what the diff would be. I'm creating a ticket to track this work for the next major release.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 60 insertions(+), 60 deletions(-))
google-beta provider: Diff ( 7 files changed, 60 insertions(+), 60 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 42 insertions(+), 56 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field http_check.auth_info.password_wo within resource google_monitoring_uptime_check_config was added to exactly one of - reference
• Field http_check.auth_info.password within resource google_monitoring_uptime_check_config was added to exactly one of - reference
• Field secret_data_wo_version changed from TypeInt to TypeString on google_secret_manager_secret_version - reference
• Field secret_data_wo_version default value changed from 0 to <nil> on google_secret_manager_secret_version - reference
• Field sensitive_params.secret_access_key_wo_version changed from TypeInt to TypeString on google_bigquery_data_transfer_config - reference
• Field sensitive_params.secret_access_key_wo within resource google_bigquery_data_transfer_config was added to exactly one of - reference
• Field sensitive_params.secret_access_key within resource google_bigquery_data_transfer_config was added to exactly one of - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_bigquery_data_transfer_config (12 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_bigquery_data_transfer_config" "primary" {
  sensitive_params {
    secret_access_key            = # value needed
    secret_access_key_wo         = # value needed
    secret_access_key_wo_version = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 104
Passed tests: 95
Skipped tests: 7
Affected tests: 2

Click here to see the affected service packages

• bigquerydatatransfer
• monitoring
• secretmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDatasourceSecretManagerSecretVersion_basic
• TestAccMonitoringUptimeCheckConfig_update_wo

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDatasourceSecretManagerSecretVersion_basic [Debug log]
TestAccMonitoringUptimeCheckConfig_update_wo [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[wj-chen]

@wj-chen I'm not quite sure what doesn't match, but for context, this PR isn't actually intended to make the change - just to demonstrate what the diff would be. I'm creating a ticket to track this work for the next major release.

Ack. For bigquerydatatransfer looks like the change removes secretAccessKeyWo and secretAccessKeyWoVersion but the generated diff still shows these params just with different types and other property values, hence the confusion: https://github.com/modular-magician/terraform-provider-google/compare/c874c8109350082d1e4c75e7281013b690da3fed..a129b9af534cdee7d60b56940cc230e583c9df4b

[melinath]

Ah, yeah - if write_only: true is set, we automatically add the _wo and _wo_version fields in the downstream without needing to specify them explicitly in the config. That ensures that they're set up correctly in terms of, for example, conflicting with each other. (It's easy to do things wrong / inconsistently otherwise, as demonstrated by the fields modified in this PR.)