Add resource for Cluster Director (hypercomputecluster.googleapis.com) Cluster resource#16274
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
de8ae0b to
fc4cb0b
Compare
6bb060d to
a7702f7
Compare
…nto cluster-director-terraform
a7702f7 to
94f500f
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_hypercomputecluster_cluster" "primary" {
compute_resources {
config {
new_flex_start_instances {
machine_type = # value needed
max_duration = # value needed
zone = # value needed
}
new_reserved_instances {
reservation = # value needed
}
}
}
network_resources {
config {
existing_network {
network = # value needed
subnetwork = # value needed
}
}
}
storage_resources {
config {
existing_bucket {
bucket = # value needed
}
existing_filestore {
filestore = # value needed
}
existing_lustre {
lustre = # value needed
}
new_bucket {
autoclass {
enabled = # value needed
terminal_storage_class = # value needed
}
hierarchical_namespace {
enabled = # value needed
}
}
new_filestore {
description = # value needed
file_shares {
capacity_gb = # value needed
file_share = # value needed
}
filestore = # value needed
protocol = # value needed
tier = # value needed
}
new_lustre {
capacity_gb = # value needed
description = # value needed
filesystem = # value needed
lustre = # value needed
}
}
id = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_hypercomputecluster_cluster" "primary" {
compute_resources {
config {
new_flex_start_instances {
machine_type = # value needed
max_duration = # value needed
zone = # value needed
}
new_reserved_instances {
reservation = # value needed
}
}
}
network_resources {
config {
existing_network {
network = # value needed
subnetwork = # value needed
}
}
}
storage_resources {
config {
existing_bucket {
bucket = # value needed
}
existing_filestore {
filestore = # value needed
}
existing_lustre {
lustre = # value needed
}
new_bucket {
autoclass {
enabled = # value needed
terminal_storage_class = # value needed
}
hierarchical_namespace {
enabled = # value needed
}
}
new_filestore {
description = # value needed
file_shares {
capacity_gb = # value needed
file_share = # value needed
}
filestore = # value needed
protocol = # value needed
tier = # value needed
}
new_lustre {
capacity_gb = # value needed
description = # value needed
filesystem = # value needed
lustre = # value needed
}
}
id = # value needed
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_hypercomputecluster_cluster" "primary" {
compute_resources {
config {
new_flex_start_instances {
machine_type = # value needed
max_duration = # value needed
zone = # value needed
}
new_reserved_instances {
reservation = # value needed
}
}
}
network_resources {
config {
existing_network {
network = # value needed
subnetwork = # value needed
}
}
}
storage_resources {
config {
existing_bucket {
bucket = # value needed
}
existing_filestore {
filestore = # value needed
}
existing_lustre {
lustre = # value needed
}
new_bucket {
autoclass {
enabled = # value needed
terminal_storage_class = # value needed
}
hierarchical_namespace {
enabled = # value needed
}
}
new_filestore {
description = # value needed
file_shares {
capacity_gb = # value needed
file_share = # value needed
}
filestore = # value needed
protocol = # value needed
tier = # value needed
}
new_lustre {
capacity_gb = # value needed
description = # value needed
filesystem = # value needed
lustre = # value needed
}
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 6012 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
1 similar comment
Tests analyticsTotal tests: 6012 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 6013 Click here to see the affected service packages
Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_hypercomputecluster_cluster" "primary" {
compute_resources {
config {
new_flex_start_instances {
machine_type = # value needed
max_duration = # value needed
zone = # value needed
}
new_reserved_instances {
reservation = # value needed
}
}
}
network_resources {
config {
existing_network {
network = # value needed
subnetwork = # value needed
}
}
}
storage_resources {
config {
existing_bucket {
bucket = # value needed
}
existing_filestore {
filestore = # value needed
}
existing_lustre {
lustre = # value needed
}
new_bucket {
autoclass {
enabled = # value needed
terminal_storage_class = # value needed
}
hierarchical_namespace {
enabled = # value needed
}
}
new_filestore {
description = # value needed
file_shares {
capacity_gb = # value needed
file_share = # value needed
}
filestore = # value needed
protocol = # value needed
tier = # value needed
}
new_lustre {
capacity_gb = # value needed
description = # value needed
filesystem = # value needed
lustre = # value needed
}
}
}
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Tests analyticsTotal tests: 6013 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
|
|
@c2thorn successful run of existing test locally: https://gist.github.com/annuay-google/7438af619e0df1b75ac16c89c2fc7b2b |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. |
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 6072 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🔴 Tests failed when rerunning REPLAYING mode: Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
hao-nan-li
left a comment
There was a problem hiding this comment.
LGTM overall, pending on VCR tests to pass.
|
/gcbrun |
|
rerunning after quota cleanup |
|
instead of the full build, I'm going to try to rerun the test directly at https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLEBETA_MODMAGICIAN_VCR/615869 |
|
queue is really long at this point. I'll go ahead and approve the merge after talking with another member on the team. |
a236770
…) Cluster resource (GoogleCloudPlatform#16274) Co-authored-by: Cameron Thornton <camthornton@google.com>
…) Cluster resource (GoogleCloudPlatform#16274) Co-authored-by: Cameron Thornton <camthornton@google.com>
…) Cluster resource (GoogleCloudPlatform#16274) Co-authored-by: Cameron Thornton <camthornton@google.com>
Creating a new terraform resource for Cluster Director (https://docs.cloud.google.com/cluster-director/docs).