Skip to content

Add resource for Cluster Director (hypercomputecluster.googleapis.com) Cluster resource#16274

Merged
c2thorn merged 17 commits intoGoogleCloudPlatform:mainfrom
annuay-google:cluster-director-terraform
Feb 20, 2026
Merged

Add resource for Cluster Director (hypercomputecluster.googleapis.com) Cluster resource#16274
c2thorn merged 17 commits intoGoogleCloudPlatform:mainfrom
annuay-google:cluster-director-terraform

Conversation

@annuay-google
Copy link
Copy Markdown
Contributor

@annuay-google annuay-google commented Feb 2, 2026

Creating a new terraform resource for Cluster Director (https://docs.cloud.google.com/cluster-director/docs).

`google_hypercomputecluster_cluster`

@github-actions github-actions Bot requested a review from hao-nan-li February 2, 2026 17:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Comment thread mmv1/templates/terraform/examples/hypercomputecluster_cluster_basic.tf.tmpl Outdated
@annuay-google annuay-google force-pushed the cluster-director-terraform branch from de8ae0b to fc4cb0b Compare February 9, 2026 12:54
Comment thread mmv1/products/hypercomputecluster/Cluster.yaml Outdated
@annuay-google annuay-google force-pushed the cluster-director-terraform branch from a7702f7 to 94f500f Compare February 10, 2026 09:56
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 5699 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 5689 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1679 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_hypercomputecluster_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_hypercomputecluster_cluster" "primary" {
  compute_resources {
    config {
      new_flex_start_instances {
        machine_type = # value needed
        max_duration = # value needed
        zone         = # value needed
      }
      new_reserved_instances {
        reservation = # value needed
      }
    }
  }
  network_resources {
    config {
      existing_network {
        network    = # value needed
        subnetwork = # value needed
      }
    }
  }
  storage_resources {
    config {
      existing_bucket {
        bucket = # value needed
      }
      existing_filestore {
        filestore = # value needed
      }
      existing_lustre {
        lustre = # value needed
      }
      new_bucket {
        autoclass {
          enabled                = # value needed
          terminal_storage_class = # value needed
        }
        hierarchical_namespace {
          enabled = # value needed
        }
      }
      new_filestore {
        description = # value needed
        file_shares {
          capacity_gb = # value needed
          file_share  = # value needed
        }
        filestore = # value needed
        protocol  = # value needed
        tier      = # value needed
      }
      new_lustre {
        capacity_gb = # value needed
        description = # value needed
        filesystem  = # value needed
        lustre      = # value needed
      }
    }
    id = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 5699 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 5689 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1679 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_hypercomputecluster_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_hypercomputecluster_cluster" "primary" {
  compute_resources {
    config {
      new_flex_start_instances {
        machine_type = # value needed
        max_duration = # value needed
        zone         = # value needed
      }
      new_reserved_instances {
        reservation = # value needed
      }
    }
  }
  network_resources {
    config {
      existing_network {
        network    = # value needed
        subnetwork = # value needed
      }
    }
  }
  storage_resources {
    config {
      existing_bucket {
        bucket = # value needed
      }
      existing_filestore {
        filestore = # value needed
      }
      existing_lustre {
        lustre = # value needed
      }
      new_bucket {
        autoclass {
          enabled                = # value needed
          terminal_storage_class = # value needed
        }
        hierarchical_namespace {
          enabled = # value needed
        }
      }
      new_filestore {
        description = # value needed
        file_shares {
          capacity_gb = # value needed
          file_share  = # value needed
        }
        filestore = # value needed
        protocol  = # value needed
        tier      = # value needed
      }
      new_lustre {
        capacity_gb = # value needed
        description = # value needed
        filesystem  = # value needed
        lustre      = # value needed
      }
    }
    id = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 5699 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 5689 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1679 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_hypercomputecluster_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_hypercomputecluster_cluster" "primary" {
  compute_resources {
    config {
      new_flex_start_instances {
        machine_type = # value needed
        max_duration = # value needed
        zone         = # value needed
      }
      new_reserved_instances {
        reservation = # value needed
      }
    }
  }
  network_resources {
    config {
      existing_network {
        network    = # value needed
        subnetwork = # value needed
      }
    }
  }
  storage_resources {
    config {
      existing_bucket {
        bucket = # value needed
      }
      existing_filestore {
        filestore = # value needed
      }
      existing_lustre {
        lustre = # value needed
      }
      new_bucket {
        autoclass {
          enabled                = # value needed
          terminal_storage_class = # value needed
        }
        hierarchical_namespace {
          enabled = # value needed
        }
      }
      new_filestore {
        description = # value needed
        file_shares {
          capacity_gb = # value needed
          file_share  = # value needed
        }
        filestore = # value needed
        protocol  = # value needed
        tier      = # value needed
      }
      new_lustre {
        capacity_gb = # value needed
        description = # value needed
        filesystem  = # value needed
        lustre      = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6012
Passed tests: 5374
Skipped tests: 634
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_update

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6012
Passed tests: 5374
Skipped tests: 634
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6013
Passed tests: 5374
Skipped tests: 634
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
  • TestAccFolderIamPolicy_basic
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample [Error message] [Debug log]
TestAccHypercomputeclusterCluster_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample [Error message] [Debug log]
TestAccHypercomputeclusterCluster_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccFolderIamPolicy_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample [Error message] [Debug log]
TestAccHypercomputeclusterCluster_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@c2thorn
Copy link
Copy Markdown
Member

c2thorn commented Feb 10, 2026

/gcbrun

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 5699 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 5689 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1679 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_hypercomputecluster_cluster (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_hypercomputecluster_cluster" "primary" {
  compute_resources {
    config {
      new_flex_start_instances {
        machine_type = # value needed
        max_duration = # value needed
        zone         = # value needed
      }
      new_reserved_instances {
        reservation = # value needed
      }
    }
  }
  network_resources {
    config {
      existing_network {
        network    = # value needed
        subnetwork = # value needed
      }
    }
  }
  storage_resources {
    config {
      existing_bucket {
        bucket = # value needed
      }
      existing_filestore {
        filestore = # value needed
      }
      existing_lustre {
        lustre = # value needed
      }
      new_bucket {
        autoclass {
          enabled                = # value needed
          terminal_storage_class = # value needed
        }
        hierarchical_namespace {
          enabled = # value needed
        }
      }
      new_filestore {
        description = # value needed
        file_shares {
          capacity_gb = # value needed
          file_share  = # value needed
        }
        filestore = # value needed
        protocol  = # value needed
        tier      = # value needed
      }
      new_lustre {
        capacity_gb = # value needed
        description = # value needed
        filesystem  = # value needed
        lustre      = # value needed
      }
    }
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 6013
Passed tests: 5375
Skipped tests: 634
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAccessContextManager__service_perimeter_dry_run_egress_policy
  • TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy
  • TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample
  • TestAccHypercomputeclusterCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccHypercomputeclusterCluster_hypercomputeclusterClusterBasicExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccHypercomputeclusterCluster_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Comment thread mmv1/products/hypercomputecluster/Cluster.yaml Outdated
Comment thread mmv1/products/hypercomputecluster/Cluster.yaml
Comment thread mmv1/products/hypercomputecluster/Cluster.yaml
Comment thread mmv1/products/hypercomputecluster/Cluster.yaml
Comment thread mmv1/products/hypercomputecluster/Cluster.yaml
@annuay-google
Copy link
Copy Markdown
Contributor Author

some feedback from looking through TestAccHypercomputeclusterCluster_new

@c2thorn even after adding the above fixes, the TestAccHypercomputeclusterCluster_new test still shows a diff for the storage. Specifically:

user@annuay-ws:~/go/src/github.com/hashicorp/terraform-provider-google$ make testacc TEST=./google/services/hypercomputecluster TESTARGS='-run=TestAccHypercomputeclusterCluster_new$$'
sh -c "'/home/user/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/hypercomputecluster -v -run=TestAccHypercomputeclusterCluster_new$ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccHypercomputeclusterCluster_new
=== PAUSE TestAccHypercomputeclusterCluster_new
=== CONT  TestAccHypercomputeclusterCluster_new
    resource_hypercomputecluster_cluster_test.go:100: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # google_hypercomputecluster_cluster.cluster will be updated in-place
          ~ resource "google_hypercomputecluster_cluster" "cluster" {
                id               = "projects/cloud-hypercomp-dev/locations/us-central1/clusters/tf090iz89c"
                name             = "projects/cloud-hypercomp-dev/locations/us-central1/clusters/tf090iz89c"
                # (9 unchanged attributes hidden)
        
              - storage_resources {
                  - bucket    = [
                      - {
                          - bucket = "bucket-new-1-090iz89c"
                        },
                    ] -> null
                  - filestore = [] -> null
                  - id        = "bucket-new-1" -> null
                  - lustre    = [] -> null
        
                  - config {
                      - new_bucket {
                          - bucket        = "bucket-new-1-090iz89c" -> null
                          - storage_class = "STANDARD" -> null
                        }
                    }
                }
              - storage_resources {
                  - bucket    = [
                      - {
                          - bucket = "bucket-new-2-090iz89c"
                        },
                    ] -> null
                  - filestore = [] -> null
                  - id        = "bucket-new-2" -> null
                  - lustre    = [] -> null
        
                  - config {
                      - new_bucket {
                          - bucket        = "bucket-new-2-090iz89c" -> null
                            # (1 unchanged attribute hidden)
        
                          - autoclass {
                              - enabled = true -> null
                            }
                        }
                    }
                }
              + storage_resources {
                  + bucket    = (known after apply)
                  + filestore = (known after apply)
                  + id        = "bucket-new-2"
                  + lustre    = (known after apply)
        
                  + config {
                      + new_bucket {
                          + bucket        = "bucket-new-2-090iz89c"
                            # (1 unchanged attribute hidden)
        
                          + autoclass {
                              + enabled = true
                            }
                        }
                    }
                }
              + storage_resources {
                  + bucket    = [
                      + {
                          + bucket = "bucket-new-1-090iz89c"
                        },
                    ]
                  + filestore = (known after apply)
                  + id        = "bucket-new-1"
                  + lustre    = (known after apply)
        
                  + config {
                      + new_bucket {
                          + bucket        = "bucket-new-1-090iz89c"
                          + storage_class = "STANDARD"
                        }
                    }
                }
        
                # (6 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

@annuay-google
Copy link
Copy Markdown
Contributor Author

@c2thorn successful run of existing test locally: https://gist.github.com/annuay-google/7438af619e0df1b75ac16c89c2fc7b2b

@c2thorn c2thorn reopened this Feb 19, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 6031 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 6021 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1668 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 6043 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 6033 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1677 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 6045 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 6035 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1677 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 6045 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 14 files changed, 6035 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 3 files changed, 1677 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

Missing service labels

The following new resources do not have corresponding service labels:

  • google_hypercomputecluster_cluster

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccHypercomputeclusterCluster_existing

Tests analytics

Total tests: 6072
Passed tests: 5432
Skipped tests: 636
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate
  • TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController
  • TestAccHypercomputeclusterCluster_new
  • TestAccHypercomputeclusterCluster_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Debug log]
TestAccHypercomputeclusterCluster_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccGKEHubFeatureMembership_gkehubFeatureAcmUpdate [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController [Error message] [Debug log]
TestAccHypercomputeclusterCluster_new [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, pending on VCR tests to pass.

@c2thorn
Copy link
Copy Markdown
Member

c2thorn commented Feb 19, 2026

/gcbrun

@c2thorn
Copy link
Copy Markdown
Member

c2thorn commented Feb 19, 2026

rerunning after quota cleanup

@c2thorn
Copy link
Copy Markdown
Member

c2thorn commented Feb 20, 2026

instead of the full build, I'm going to try to rerun the test directly at https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLEBETA_MODMAGICIAN_VCR/615869

@c2thorn
Copy link
Copy Markdown
Member

c2thorn commented Feb 20, 2026

queue is really long at this point. I'll go ahead and approve the merge after talking with another member on the team.
We'll need to monitor the nightly run of this test, and if there is a failure we have to revert. Only doing this since it passed locally.

@c2thorn c2thorn added this pull request to the merge queue Feb 20, 2026
Merged via the queue into GoogleCloudPlatform:main with commit a236770 Feb 20, 2026
22 of 25 checks passed
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Feb 24, 2026
…) Cluster resource (GoogleCloudPlatform#16274)

Co-authored-by: Cameron Thornton <camthornton@google.com>
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
…) Cluster resource (GoogleCloudPlatform#16274)

Co-authored-by: Cameron Thornton <camthornton@google.com>
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
…) Cluster resource (GoogleCloudPlatform#16274)

Co-authored-by: Cameron Thornton <camthornton@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants