alloydb: promote observability_config to GA in Instance resource

[jahnavi2k]

Promoted observability_config field to GA. It is now available in the standard google provider.

alloydb: promoted observability_config field to GA.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 292 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
terraform-google-conversion: Diff ( 3 files changed, 271 insertions(+))

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

manual GA test (you won't have access to this): https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_ALLOYDB/605801

[melinath]

7/15 Alloydb instance tests failed in GA with errors like:

Error: Error creating Instance: googleapi: Error 400: Invalid JSON payload received. Unknown name "assistiveExperiencesEnabled" at 'instance.observability_config': Cannot find field.

Let me know if you need more information!

[jahnavi2k]

7/15 Alloydb instance tests failed in GA with errors like:

Error: Error creating Instance: googleapi: Error 400: Invalid JSON payload received. Unknown name "assistiveExperiencesEnabled" at 'instance.observability_config': Cannot find field.

Let me know if you need more information!

Done!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 295 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 30 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 281 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_alloydb_instance (113 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_alloydb_instance" "primary" {
  observability_config {
    track_client_address = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 90
Passed tests: 76
Skipped tests: 3
Affected tests: 11

Click here to see the affected service packages

• alloydb

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAlloydbInstance_ObservabilityConfig_Update
• TestAccAlloydbInstance_clientConnectionConfig
• TestAccAlloydbInstance_connectionPoolConfig
• TestAccAlloydbInstance_networkConfig
• TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag
• TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig
• TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig
• TestAccAlloydbInstance_stopstart
• TestAccAlloydbInstance_update
• TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs
• TestAccAlloydbInstance_updatePscInstanceConfig

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccAlloydbInstance_ObservabilityConfig_Update [Debug log]
TestAccAlloydbInstance_clientConnectionConfig [Debug log]
TestAccAlloydbInstance_connectionPoolConfig [Debug log]
TestAccAlloydbInstance_networkConfig [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateDatabaseFlag [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateMachineConfig [Debug log]
TestAccAlloydbInstance_secondaryInstanceUpdateQueryInsightConfig [Debug log]
TestAccAlloydbInstance_stopstart [Debug log]
TestAccAlloydbInstance_update [Debug log]
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccAlloydbInstance_updatePscInstanceConfig [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[melinath]

Manual test run: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_MMUPSTREAMTESTS_GOOGLE_PACKAGE_ALLOYDB/615295

EDIT: All passed.

[github-actions]

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

So, a couple things.

1. sorry for not catching this sooner, but it looks like this feature is only tested in TestAccAlloydbInstance_ObservabilityConfig_Update, which is behind a version guard. That'll need to be removed so that it'll run in GA. (You'll still need a version guard around assistive_experiences_enabled specifically)
2. track_client_address isn't present in any tests - it'll need to be added to one. You could put it in TestAccAlloydbInstance_ObservabilityConfig_Update with a version guard as well.

[melinath]

see above