fix(dsh-017): move the client onto configForms so the plugin activates on 0.1.7 - #23
Open
WangYiBen0 wants to merge 1 commit into
Open
WangYiBen0 wants to merge 1 commit into
WangYiBen0 wants to merge 1 commit into
Conversation
…s on 0.1.7 DSH 0.1.7-alpha.1 removed the `settingsScope` cordis service, so the client half asked for a service no host provides and sat at `pending (waiting for service: settingsScope)` — web boot then listed the whole entry as not activated, taking the IP 池 settings card with it (issue FishBottle7#20). The settings provider (@deepseek-ai/dsh-client-ui-settings) now owns the per-namespace forms, so the card binds `ctx.configForms.get('ip-pool')` instead. Both inject lists move with it — the manifest token and the entry's own `inject` are separate gates, and a stale one in either is enough to leave the fiber pending. ConfigForm's snapshot carries the same status/value/base/writable shape the card already read, so its read, save, reset, and polling paths are untouched. The client no longer imports @deepseek-ai/dsh-client-runtime: the Context type comes from @deepseek-ai/cordis, and that package is no longer a platform seed on this host, so the tsdown externals table shrinks to the seven verified seeds. @deepseek-ai/dsh-client-ui-settings has to move to 0.1.7-rc.2: the 0.1.1-rc.2 line still exports the removed settingsScope, and ConfigForm first appears in 0.1.7-alpha.1. The remaining client deps stay pinned. Client-build tests now pin the invariant that caused this: the manifest and the entry's inject must agree, and no runtime reference to settingsScope may survive in the bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Code Warning: Writen by OpenCode Big Pickle
DSH 0.1.7-alpha.1 removed the
settingsScopecordis service, so the client half asked for a service no host provides and sat atpending (waiting for service: settingsScope)— web boot then listed the whole entry as not activated, taking the IP 池 settings card with it (issue #20).The settings provider (@deepseek-ai/dsh-client-ui-settings) now owns the per-namespace forms, so the card binds
ctx.configForms.get('ip-pool')instead. Both inject lists move with it — the manifest token and the entry's owninjectare separate gates, and a stale one in either is enough to leave the fiber pending. ConfigForm's snapshot carries the same status/value/base/writable shape the card already read, so its read, save, reset, and polling paths are untouched.The client no longer imports @deepseek-ai/dsh-client-runtime: the Context type comes from @deepseek-ai/cordis, and that package is no longer a platform seed on this host, so the tsdown externals table shrinks to the seven verified seeds.
@deepseek-ai/dsh-client-ui-settings has to move to 0.1.7-rc.2: the 0.1.1-rc.2 line still exports the removed settingsScope, and ConfigForm first appears in 0.1.7-alpha.1. The remaining client deps stay pinned.
Client-build tests now pin the invariant that caused this: the manifest and the entry's inject must agree, and no runtime reference to settingsScope may survive in the bundle.