Conversation
Picks up the SmartScanExtension fix for sharing screenshots directly from the iOS screenshot preview thumbnail. The HybridApp ships Mobile-Expensify/iOS/SmartScanExtension, so the user-facing fix lives in that submodule rather than ios/ShareViewController in this repo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Picks up the follow-up commit that restores the String / NSURL fallback in the URL branch of loadData. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
grgia
changed the title
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
No C+ here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Bumps the
Mobile-Expensifysubmodule to pick up the iOSSmartScanExtensionfix in Expensify/Mobile-Expensify#13931.The HybridApp ships
Mobile-Expensify/iOS/SmartScanExtension, not the standaloneios/ShareViewControllerin this repo, so the user-facing fix for the screenshot-thumbnail share bug had to land in Mobile-Expensify. This PR is the App-side bump that delivers it. It contains no code changes — only the submodule pointer update.Supersedes #86984, which patched the standalone NewDot extension that doesn't reach iOS users.
Stays in draft until the Mobile-Expensify PR merges, at which point I'll repoint the submodule at the merged main commit.
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13931
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/606736
PROPOSAL:
Tests
iOS only — Android and Web are unaffected. Run on a physical iPhone with the ad-hoc HybridApp IPA built from this branch:
.png→ Share → Expensify. File loads..mp4→ Share → Expensify. File loads.file://string (formerly hung) — file-manager app sharing afile://...string → Expensify. App opens with the file loaded.After each test, verify the Expensify main app actually opens (i.e. the
DispatchGroupcompleted andopenMainAppfired).Offline tests
N/A — the share extension operates on local data before opening the app.
QA Steps
Same as Tests above on the post-merge HybridApp staging build.
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
iOS: Native
Will attach a screen recording of the screenshot-thumbnail share flow on a physical iOS device once the Mobile-Expensify PR merges and the bumped IPA is built.
Other platforms: N/A — iOS-only change.