Feat: add codeium_os and codeium_arch options#341
Merged
pqn merged 2 commits intoExafunction:mainfrom Mar 21, 2024
Bleksak:main
Merged
Feat: add codeium_os and codeium_arch options#341pqn merged 2 commits intoExafunction:mainfrom Bleksak:main
pqn merged 2 commits intoExafunction:mainfrom
Bleksak:main
Conversation
|
|
pqn
reviewed
Mar 20, 2024
pqn
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling system("uname") twice on startup is very slow,
instead let us set the os and arch options manually, and call system() only when needed
This will also help neovim users as they can use vim.uv.os_uname() function which executes much faster.