Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
commented
Sep 23, 2026
peachbits
requested changes
Sep 25, 2026
peachbits
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes for the PR body and one cleaner alignment, both inline. The plugin is disabled until the release env has a WIZARDSWAP_INIT entry, which the description currently presents as optional.
Default the WIZARDSWAP_INIT apiKey to '' like its neighbors; the plugin's asOptionalBlank cleaner now treats the blank key as unset. Answers the envConfig review thread. Fixup-for: human
Contributor
Author
|
The PR body lists the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Enables the WizardSwap central swap provider added in the exchange-plugins PR. The change registers
wizardswapincorePlugins, addsWIZARDSWAP_INIT(affiliateapiKey) toenvConfig, and maps its icon inCategoriesActions.Release-blocking steps (the provider does not ship without both):
WIZARDSWAP_INITentry to the releaseenv.json. Like everyasCorePluginInitprovider, a missing entry makes the cleaner returnfalseand edge-core-js skips the plugin, so WizardSwap never quotes. SetapiKeyto the WizardSwap affiliate id from the team password manager; a blank key still loads the plugin (it quotes and orders without one) but swaps go uncredited. Referral payouts are not active on the account yet, which takes an email to support@wizardswap.io naming the referring site./exchangeIcons/wizardswap/icon.png. Until it is uploaded (the URL returns 403), the swap scenes show a blank provider icon.Tested on the iOS simulator against the linked plugin. Without the affiliate key: a real ZEC to BTC swap of 0.0061844 ZEC ran to completion (order
NI53JPQ4), the provider reportedfinished, and 10285 sats (the quoted 0.00010285 BTC) arrived in the BTC wallet. WithWIZARDSWAP_INIT.apiKeyset in the build: a real DASH to DOGE swap of 0.0624 DASH reached the success scene (orderJGZ0BGYR, deposit tx5c6cf027...c99a8) against a quote of 37.25881404 DOGE, and the provider reportedconfirming. The screenshots of the quote, success, transaction details and exchange details below are from the second run.ZANO is not orderable at WizardSwap in either direction (tested 2026-09-26 UTC). With WizardSwap as the only enabled provider, BTC to ZANO for $20 showed "No enabled exchanges support BTC to ZANO." while BTC to ETH quoted 0.0072707 ETH through WizardSwap in the same session. ZANO to BTC for $20 stopped at "Insufficient Funds" because WizardSwap has no route that can fund a ZANO wallet. The provider's
/api/pairslistszanoonly as a source coin, and its API answers everyzanoestimate with "Insufficient liquidity." while other pairs quote within the same seconds, so this is the provider's state and not IP throttling. No ZANO order was created. The exchange-plugins PR carries the API-level detail; the Zano screenshots are in the second evidence batch below.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
3481092Enable WizardSwap swap provider
2026-09-23
1. wizardswap quote
2. swap success
3. tx details
4. exchange details
953e151fixup! Enable WizardSwap swap provider
2026-09-26
5. btc to zano error
6. btc to eth control quote
8. zano to btc unfunded