Skip to content

Fixing Python Version Link#292

Closed
StephenDonaldson wants to merge 1 commit intoDjangoGirls:masterfrom
StephenDonaldson:master
Closed

Fixing Python Version Link#292
StephenDonaldson wants to merge 1 commit intoDjangoGirls:masterfrom
StephenDonaldson:master

Conversation

@StephenDonaldson
Copy link
Copy Markdown

Changing URL from 342 to 343 so that it links to version 3.4.3 and not 3.4.2.

Changing URL from 342 to 343 so that it links to version 3.4.3 and not 3.4.2.
@ProProgrammer
Copy link
Copy Markdown
Contributor

I know it can be tedious but please look for previously created pull requests before submitting a new one.
#279 and #268

@StephenDonaldson
Copy link
Copy Markdown
Author

I did; the issue still persists that this is inconsistent with the text afterwards. Either this link needs to be changed or the text after needs to be changed. Currently it's causing confusion for users of the tutorial.

@ProProgrammer
Copy link
Copy Markdown
Contributor

@asendecka Should all such pull requests be closed and instead one be created for change all mentions of Python 3.4.3 to Python 3.4.2 and we keep that consistent at least till heroku starts supporting Python 3.4.3 environment.

Although it doesn't make much of a difference if we have Python 3.4.3 on our local system and 3.4.2 in runtime for heroku but this can be confusing keeping in mind this tutorial is aimed for beginners.

@aniav
Copy link
Copy Markdown
Member

aniav commented Mar 27, 2015

I believe we don't have any specification as how such situations should be treated. Until this point most pull requests consisted of a full change. I believe we can just wait a bit until Heroku updates its runtime and then merge both pull requests. Is this a good solution? :)

@aniav
Copy link
Copy Markdown
Member

aniav commented Mar 27, 2015

Ok, sorry about me being messy. I am closing this pull request in favour of #279 which has this change and more - it will be cleaner with one PR for this. Thank you!

@aniav aniav closed this Mar 27, 2015
@ProProgrammer
Copy link
Copy Markdown
Contributor

Very well 👍

@ProProgrammer
Copy link
Copy Markdown
Contributor

However a pull request has to be submitted to change all references of 3.4.3 to 3.4.2 until Heroku starts supporting python 3.4.3 runtime as I believe people find it confusing to first having to specifically be instructed to install and setup 3.4.3 on their local machines but then be asked to mention 3.4.2 in runtime well at the time of deployment.

@aniav
Copy link
Copy Markdown
Member

aniav commented Mar 27, 2015

There i fixed it for you in 83fd4e5 :)

@ProProgrammer
Copy link
Copy Markdown
Contributor

Superb 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants