Add pyc files to .gitignore#291
Closed
powerfool wants to merge 1 commit intoDjangoGirls:masterfrom
powerfool:master
Closed
Add pyc files to .gitignore#291powerfool wants to merge 1 commit intoDjangoGirls:masterfrom powerfool:master
powerfool wants to merge 1 commit intoDjangoGirls:masterfrom
powerfool:master
Conversation
Contributor
|
I think because this tutorial uses python3, that there shouldn't be |
Member
|
I believe @sodevious is right about pyc files. Therefore I will close this pull request, thank you! ✨ |
Author
|
You're right, my bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should make sure pyc files don't end up in the production environment as this can cause issues since we use a different database locally and on Heroku.
This adds "*.pyc" to .gitignore so they are excluded.
It's also recommended in the "Getting started with Django" guide at Heroku:
https://devcenter.heroku.com/articles/getting-started-with-django#gitignore
I have seen some people doing the tutorial having issues with their database, like here:
http://stackoverflow.com/questions/28788452/django-via-heroku-auth-user-error
I had the same issue and I solved it by removing pyc files locally and in production and making sure they are never sent again to Heroku.