Skip to content

Add pyc files to .gitignore#291

Closed
powerfool wants to merge 1 commit intoDjangoGirls:masterfrom
powerfool:master
Closed

Add pyc files to .gitignore#291
powerfool wants to merge 1 commit intoDjangoGirls:masterfrom
powerfool:master

Conversation

@powerfool
Copy link
Copy Markdown

We should make sure pyc files don't end up in the production environment as this can cause issues since we use a different database locally and on Heroku.
This adds "*.pyc" to .gitignore so they are excluded.

It's also recommended in the "Getting started with Django" guide at Heroku:
https://devcenter.heroku.com/articles/getting-started-with-django#gitignore

I have seen some people doing the tutorial having issues with their database, like here:
http://stackoverflow.com/questions/28788452/django-via-heroku-auth-user-error

I had the same issue and I solved it by removing pyc files locally and in production and making sure they are never sent again to Heroku.

@sodevious
Copy link
Copy Markdown
Contributor

I think because this tutorial uses python3, that there shouldn't be .pyc files, just __pycache__ folders?

@aniav
Copy link
Copy Markdown
Member

aniav commented Mar 27, 2015

I believe @sodevious is right about pyc files. Therefore I will close this pull request, thank you! ✨

@aniav aniav closed this Mar 27, 2015
@powerfool
Copy link
Copy Markdown
Author

You're right, my bad.
Perhaps add a note about that though. Some people might go with the same settings to a new project without using python 3, they wouldn't know what's wrong.
Thanks for reviewing though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants