Skip to content

Link not working#270

Closed
mauricioabreu wants to merge 1 commit into
DjangoGirls:masterfrom
mauricioabreu:patch-2
Closed

Link not working#270
mauricioabreu wants to merge 1 commit into
DjangoGirls:masterfrom
mauricioabreu:patch-2

Conversation

@mauricioabreu
Copy link
Copy Markdown

Added 'en' as default redirect.

Added 'en' as default redirect.
@bmispelon
Copy link
Copy Markdown
Contributor

Hi,

I don't think we need to add a default language.
The current link uses ./ at the beginning which makes it relative and so it should work in all languages.

Thanks! 💨

@bmispelon bmispelon closed this Mar 8, 2015
@mauricioabreu
Copy link
Copy Markdown
Author

Ok, but the link still does not work.
1 - Go to https://github.com/DjangoGirls/tutorial
2 - Try to click the link
3 - Page not found

:-)

@bmispelon
Copy link
Copy Markdown
Contributor

Oh, I see. You're navigating directly from github.

Our tutorial is meant to be viewed from http://tutorial.djangogirls.org.
I don't know if there's a way to support both github and our normal tutorial (which is translated in 3 languages).

@mauricioabreu mauricioabreu deleted the patch-2 branch March 8, 2015 13:47
@mauricioabreu
Copy link
Copy Markdown
Author

Yep! It is ok!
I did not know you were moving. Last time I checked this repo it had no translation to other languages.

Thanks for reviewing my patch though! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants