Skip to content

Deployment needs a persistent database#158

Merged
olasitarska merged 4 commits into
DjangoGirls:masterfrom
goranche:master
Nov 5, 2014
Merged

Deployment needs a persistent database#158
olasitarska merged 4 commits into
DjangoGirls:masterfrom
goranche:master

Conversation

@goranche
Copy link
Copy Markdown
Contributor

Added instructions for PostgreSQL database creation in the deploy chapter (Heroku no longer creates a default database when creating an application)

@goranche
Copy link
Copy Markdown
Contributor Author

oh... serves me right for not checking other PRs first 😊
this is a "duplicate" of #146

Comment thread deploy/README.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this wrong? Heroku won't create a db for us, as you stated below.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running this command will create it on Heroku... might have stated that differently, I agree
changed, thanks 😉

@syndbg
Copy link
Copy Markdown
Contributor

syndbg commented Oct 31, 2014

I personally like this extra info compared to #146.

👍

@goranche
Copy link
Copy Markdown
Contributor Author

thanks 👍

@domenkozar
Copy link
Copy Markdown
Contributor

+1

olasitarska added a commit that referenced this pull request Nov 5, 2014
Deployment needs a persistent database
@olasitarska olasitarska merged commit f2baefc into DjangoGirls:master Nov 5, 2014
@olasitarska
Copy link
Copy Markdown
Member

Thanks for the contribution @goranche! <3

@goranche
Copy link
Copy Markdown
Contributor Author

goranche commented Nov 7, 2014

glad to help 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants