Fixed #82 -- Improved the chapter on dictionaries.#107
Merged
olasitarska merged 1 commit intoDjangoGirls:masterfrom Aug 10, 2014
Merged
Fixed #82 -- Improved the chapter on dictionaries.#107olasitarska merged 1 commit intoDjangoGirls:masterfrom
olasitarska merged 1 commit intoDjangoGirls:masterfrom
Conversation
Member
There was a problem hiding this comment.
should be: an empty dictionary
Member
|
I added some feedback here. Do you mind fixing?:) |
Contributor
Author
|
Of course not, I'll fix it as soon as I'm back at the computer. Thanks!
|
Thanks to @kerstin for the feedback.
Contributor
Author
|
@olasitarska: I fixed all the mistakes you found, thanks. @oinopion @kerstin: Does that look good? Is there something else I could address in this PR? |
Member
|
@bmispelon thanks! ready to be merged for me, but let's hear from @oinopion and @kerstin :) |
|
Looking goooooooooood! Thanks so much for the improvement, @bmispelon. ((: |
olasitarska
added a commit
that referenced
this pull request
Aug 10, 2014
Fixed #82 -- Improved the chapter on dictionaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @kerstin for the feedback.