Skip to content

feat(react-dom): Add hydrateRoot#53857

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:feat/react-dom/hydrateRoot
Jun 18, 2021
Merged

feat(react-dom): Add hydrateRoot#53857
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
eps1lon:feat/react-dom/hydrateRoot

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented Jun 16, 2021

Please fill in this template.

If changing an existing definition:

@eps1lon eps1lon marked this pull request as ready for review June 16, 2021 08:38
@eps1lon eps1lon requested a review from Jessidhia as a code owner June 16, 2021 08:38
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Jun 16, 2021

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53857,
  "author": "eps1lon",
  "headCommitOid": "cbc77155235ab97f2353a5167602db4a4d3a1147",
  "lastPushDate": "2021-06-16T08:11:57.000Z",
  "lastActivityDate": "2021-06-18T05:44:56.000Z",
  "mergeOfferDate": "2021-06-18T00:08:34.000Z",
  "mergeRequestDate": "2021-06-18T05:44:56.000Z",
  "mergeRequestUser": "eps1lon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "react-dom",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-dom/next.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-dom/test/next-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "MartynasZilinskas",
        "theruther4d",
        "Jessidhia",
        "eps1lon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-06-18T00:07:56.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 862170672,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. labels Jun 16, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @MartynasZilinskas @theruther4d @Jessidhia — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 18, 2021
@typescript-bot
Copy link
Copy Markdown
Contributor

@eps1lon Everything looks good here. Great job! I am ready to merge this PR (at cbc7715) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@MartynasZilinskas, @theruther4d, @Jessidhia: you can do this too.)

@eps1lon
Copy link
Copy Markdown
Collaborator Author

eps1lon commented Jun 18, 2021

Ready to merge

@typescript-bot typescript-bot merged commit 02de9de into DefinitelyTyped:master Jun 18, 2021
@eps1lon eps1lon deleted the feat/react-dom/hydrateRoot branch June 18, 2021 05:48
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/react-dom@17.0.8 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants