feat(react-dom): Add hydrateRoot#53857
Conversation
|
@eps1lon Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53857,
"author": "eps1lon",
"headCommitOid": "cbc77155235ab97f2353a5167602db4a4d3a1147",
"lastPushDate": "2021-06-16T08:11:57.000Z",
"lastActivityDate": "2021-06-18T05:44:56.000Z",
"mergeOfferDate": "2021-06-18T00:08:34.000Z",
"mergeRequestDate": "2021-06-18T05:44:56.000Z",
"mergeRequestUser": "eps1lon",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react-dom",
"kind": "edit",
"files": [
{
"path": "types/react-dom/next.d.ts",
"kind": "definition"
},
{
"path": "types/react-dom/test/next-tests.tsx",
"kind": "test"
}
],
"owners": [
"MartynasZilinskas",
"theruther4d",
"Jessidhia",
"eps1lon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2021-06-18T00:07:56.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 862170672,
"ciResult": "pass"
} |
|
🔔 @MartynasZilinskas @theruther4d @Jessidhia — please review this PR in the next few days. Be sure to explicitly select |
|
@eps1lon Everything looks good here. Great job! I am ready to merge this PR (at cbc7715) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@MartynasZilinskas, @theruther4d, @Jessidhia: you can do this too.) |
|
Ready to merge |
|
I just published |
Please fill in this template.
npm test <package to test>.If changing an existing definition:
[ ]If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.