Handle System_Settings errors better in middleware #13982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The try-except here was catching all exceptions which would hide any structural problems like missing columns due to migration problems as it was swallowing the errors and return a default System_Settings object.
I tried catching only specific errors or returning
Noneinstead, but this would break startup in too many places and would prevent users from being able to start any container to go into and fix problems.This PR now adds displaying of error messages in the UI to make it clear "something is wrong".