Add test_type mismatch validation during reimport (#10219) #13975
+345
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation in consolidate_dynamic_tests to detect test_type mismatches during reimport - Raise ValidationError with descriptive message when test_type doesn't match - Validation occurs before any findings are processed or deduplication starts - Add test cases for matching test_type, mismatched test_type, and initial import scenarios - Create test data files for generic parser with different test types Fixes DefectDojo#10219
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
Member
Author
|
Every time I look at this feature I have to find out how it works. To help myself and other I added a short piece of documentation, let me know if that makes sense. |
valentijnscholten
changed the title
Maffooch
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #10219 where DefectDojo silently accepts test_type mismatches during reimport.
Changes
consolidate_dynamic_testsmethod to detect test_type mismatches during reimportValidationErrorwith descriptive message when test_type doesn't match existing testTesting
All test cases pass:
test_import_generic_with_custom_test_type- Initial import creates test correctlytest_reimport_generic_with_matching_test_type- Reimport with matching test_type succeedstest_reimport_generic_with_different_test_type- Reimport with different test_type raises ValidationErrorRelated Issue
Fixes #10219