Skip to content

Fix FileUpload.copy() to prevent title length exceeding 100 chars #13968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentijnscholten wants to merge 1 commit into
base: bugfix
Choose a base branch
from
+6 −1
Open

Fix FileUpload.copy() to prevent title length exceeding 100 chars #13968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dojo/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,12 @@ def delete(self, *args, **kwargs):
def copy(self):
copy = copy_model_util(self)
# Add unique modifier to file name
copy.title = f"{self.title} - clone-{str(uuid4())[:8]}"
# Truncate title to ensure it doesn't exceed max_length (100) when appending suffix
# Suffix " - clone-{8 chars}" is 17 characters, so truncate to 83 chars
clone_suffix = f" - clone-{str(uuid4())[:8]}"
max_title_length = 100 - len(clone_suffix)
truncated_title = self.title[:max_title_length] if len(self.title) > max_title_length else self.title
copy.title = f"{truncated_title}{clone_suffix}"
# Create new unique file name
current_url = self.file.url
_, current_full_filename = current_url.rsplit("/", 1)
Expand Down