Fix cross-scanner deduplication endpoint parsing (#10215) #13964
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect endpoint parsing when endpoints lack a protocol (scheme). When endpoints are converted to strings without a protocol, hyperlink.parse() misinterprets the hostname as the scheme, causing deduplication to fail. This fix normalizes endpoint strings by prepending '//' if '://' is missing, replicating the behavior from dojo/endpoint/utils.py line 265. Fixes DefectDojo#10215
valentijnscholten
requested review from
Maffooch and
mtesauro
as code owners
Maffooch
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix incorrect endpoint parsing when endpoints lack a protocol (scheme) during cross-scanner deduplication.
Problem
When endpoints are converted to strings without a protocol,
hyperlink.parse()misinterprets the hostname as the scheme, causing deduplication to fail for identical endpoints.Example: An endpoint string
10.20.197.218:6379(without protocol) gets parsed incorrectly, where10.20.197.218is treated as the scheme instead of the host.Solution
Normalize endpoint strings by prepending
//if://is missing before parsing withhyperlink.parse(). This replicates the behavior already used indojo/endpoint/utils.pyline 265.Fixes #10215