-
Notifications
You must be signed in to change notification settings - Fork 324
WIP #10393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jandro996
wants to merge
6
commits into
master
Choose a base branch
from
alejandro.gonzalez/add-apm-trace-metrics-tags
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP #10393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092335
Total [baseline] (10.795 s) : 0, 10795445
Agent [candidate] (1.105 s) : 0, 1105351
Total [candidate] (10.841 s) : 0, 10841076
section appsec
Agent [baseline] (1.268 s) : 0, 1267616
Total [baseline] (11.025 s) : 0, 11025462
Agent [candidate] (1.266 s) : 0, 1266094
Total [candidate] (11.014 s) : 0, 11014226
section iast
Agent [baseline] (1.226 s) : 0, 1225944
Total [baseline] (11.179 s) : 0, 11178804
Agent [candidate] (1.23 s) : 0, 1229898
Total [candidate] (11.186 s) : 0, 11185852
section profiling
Agent [baseline] (1.207 s) : 0, 1207020
Total [baseline] (10.84 s) : 0, 10840461
Agent [candidate] (1.206 s) : 0, 1205528
Total [candidate] (10.839 s) : 0, 10838512
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (655.889 ms) : 0, 655889
BytebuddyAgent [candidate] (663.903 ms) : 0, 663903
GlobalTracer [baseline] (284.685 ms) : 0, 284685
GlobalTracer [candidate] (288.057 ms) : 0, 288057
AppSec [baseline] (32.834 ms) : 0, 32834
AppSec [candidate] (33.328 ms) : 0, 33328
Debugger [baseline] (68.509 ms) : 0, 68509
Debugger [candidate] (69.444 ms) : 0, 69444
Remote Config [baseline] (651.338 µs) : 0, 651
Remote Config [candidate] (663.095 µs) : 0, 663
Telemetry [baseline] (9.003 ms) : 0, 9003
Telemetry [candidate] (8.931 ms) : 0, 8931
Flare Poller [baseline] (3.829 ms) : 0, 3829
Flare Poller [candidate] (3.837 ms) : 0, 3837
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (692.372 ms) : 0, 692372
BytebuddyAgent [candidate] (691.9 ms) : 0, 691900
GlobalTracer [baseline] (259.285 ms) : 0, 259285
GlobalTracer [candidate] (258.942 ms) : 0, 258942
IAST [baseline] (24.691 ms) : 0, 24691
IAST [candidate] (24.45 ms) : 0, 24450
AppSec [baseline] (173.315 ms) : 0, 173315
AppSec [candidate] (172.205 ms) : 0, 172205
Debugger [baseline] (67.415 ms) : 0, 67415
Debugger [candidate] (68.21 ms) : 0, 68210
Remote Config [baseline] (763.254 µs) : 0, 763
Remote Config [candidate] (786.101 µs) : 0, 786
Telemetry [baseline] (9.415 ms) : 0, 9415
Telemetry [candidate] (9.314 ms) : 0, 9314
Flare Poller [baseline] (3.736 ms) : 0, 3736
Flare Poller [candidate] (3.745 ms) : 0, 3745
section iast
crashtracking [baseline] (1.175 ms) : 0, 1175
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (792.122 ms) : 0, 792122
BytebuddyAgent [candidate] (795.426 ms) : 0, 795426
GlobalTracer [baseline] (257.628 ms) : 0, 257628
GlobalTracer [candidate] (257.405 ms) : 0, 257405
IAST [baseline] (27.103 ms) : 0, 27103
IAST [candidate] (27.075 ms) : 0, 27075
AppSec [baseline] (35.221 ms) : 0, 35221
AppSec [candidate] (34.495 ms) : 0, 34495
Debugger [baseline] (64.596 ms) : 0, 64596
Debugger [candidate] (66.129 ms) : 0, 66129
Remote Config [baseline] (567.225 µs) : 0, 567
Remote Config [candidate] (550.693 µs) : 0, 551
Telemetry [baseline] (8.43 ms) : 0, 8430
Telemetry [candidate] (8.481 ms) : 0, 8481
Flare Poller [baseline] (3.534 ms) : 0, 3534
Flare Poller [candidate] (3.592 ms) : 0, 3592
section profiling
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (703.474 ms) : 0, 703474
BytebuddyAgent [candidate] (701.917 ms) : 0, 701917
GlobalTracer [baseline] (221.514 ms) : 0, 221514
GlobalTracer [candidate] (221.711 ms) : 0, 221711
AppSec [baseline] (32.184 ms) : 0, 32184
AppSec [candidate] (32.218 ms) : 0, 32218
Debugger [baseline] (68.115 ms) : 0, 68115
Debugger [candidate] (68.034 ms) : 0, 68034
Remote Config [baseline] (645.111 µs) : 0, 645
Remote Config [candidate] (621.347 µs) : 0, 621
Telemetry [baseline] (8.939 ms) : 0, 8939
Telemetry [candidate] (8.919 ms) : 0, 8919
Flare Poller [baseline] (3.772 ms) : 0, 3772
Flare Poller [candidate] (3.743 ms) : 0, 3743
ProfilingAgent [baseline] (97.263 ms) : 0, 97263
ProfilingAgent [candidate] (97.146 ms) : 0, 97146
Profiling [baseline] (97.85 ms) : 0, 97850
Profiling [candidate] (97.737 ms) : 0, 97737
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099999
Total [baseline] (8.839 s) : 0, 8838705
Agent [candidate] (1.099 s) : 0, 1098788
Total [candidate] (8.845 s) : 0, 8844736
section iast
Agent [baseline] (1.224 s) : 0, 1223603
Total [baseline] (9.376 s) : 0, 9376287
Agent [candidate] (1.225 s) : 0, 1224912
Total [candidate] (9.326 s) : 0, 9326428
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (661.694 ms) : 0, 661694
BytebuddyAgent [candidate] (660.684 ms) : 0, 660684
GlobalTracer [baseline] (286.412 ms) : 0, 286412
GlobalTracer [candidate] (286.668 ms) : 0, 286668
AppSec [baseline] (33.299 ms) : 0, 33299
AppSec [candidate] (33.018 ms) : 0, 33018
Debugger [baseline] (68.052 ms) : 0, 68052
Debugger [candidate] (67.711 ms) : 0, 67711
Remote Config [baseline] (648.861 µs) : 0, 649
Remote Config [candidate] (651.581 µs) : 0, 652
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (9.113 ms) : 0, 9113
Flare Poller [baseline] (3.818 ms) : 0, 3818
Flare Poller [candidate] (3.883 ms) : 0, 3883
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.168 ms) : 0, 1168
BytebuddyAgent [baseline] (791.043 ms) : 0, 791043
BytebuddyAgent [candidate] (792.16 ms) : 0, 792160
GlobalTracer [baseline] (256.839 ms) : 0, 256839
GlobalTracer [candidate] (257.113 ms) : 0, 257113
AppSec [baseline] (34.376 ms) : 0, 34376
AppSec [candidate] (34.738 ms) : 0, 34738
Debugger [baseline] (65.077 ms) : 0, 65077
Debugger [candidate] (64.633 ms) : 0, 64633
Remote Config [baseline] (582.888 µs) : 0, 583
Remote Config [candidate] (566.251 µs) : 0, 566
Telemetry [baseline] (8.47 ms) : 0, 8470
Telemetry [candidate] (8.496 ms) : 0, 8496
Flare Poller [baseline] (3.623 ms) : 0, 3623
Flare Poller [candidate] (3.595 ms) : 0, 3595
IAST [baseline] (26.995 ms) : 0, 26995
IAST [candidate] (26.975 ms) : 0, 26975
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (19.088 ms) : 18890, 19286
. : milestone, 19088,
appsec (18.66 ms) : 18474, 18847
. : milestone, 18660,
code_origins (17.673 ms) : 17500, 17847
. : milestone, 17673,
iast (18.38 ms) : 18196, 18564
. : milestone, 18380,
profiling (18.751 ms) : 18562, 18939
. : milestone, 18751,
tracing (17.803 ms) : 17625, 17980
. : milestone, 17803,
section candidate
no_agent (19.273 ms) : 19071, 19476
. : milestone, 19273,
appsec (19.539 ms) : 19342, 19736
. : milestone, 19539,
code_origins (17.486 ms) : 17311, 17660
. : milestone, 17486,
iast (17.833 ms) : 17655, 18010
. : milestone, 17833,
profiling (18.504 ms) : 18317, 18690
. : milestone, 18504,
tracing (17.689 ms) : 17513, 17865
. : milestone, 17689,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1177, 1200
. : milestone, 1188,
iast (3.282 ms) : 3234, 3329
. : milestone, 3282,
iast_FULL (5.695 ms) : 5638, 5752
. : milestone, 5695,
iast_GLOBAL (3.654 ms) : 3600, 3708
. : milestone, 3654,
profiling (2.035 ms) : 2018, 2053
. : milestone, 2035,
tracing (1.768 ms) : 1753, 1783
. : milestone, 1768,
section candidate
no_agent (1.211 ms) : 1200, 1223
. : milestone, 1211,
iast (3.224 ms) : 3184, 3264
. : milestone, 3224,
iast_FULL (5.759 ms) : 5702, 5816
. : milestone, 5759,
iast_GLOBAL (3.498 ms) : 3443, 3553
. : milestone, 3498,
profiling (1.927 ms) : 1911, 1943
. : milestone, 1927,
tracing (1.799 ms) : 1785, 1814
. : milestone, 1799,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (15.574 s) : 15574000, 15574000
. : milestone, 15574000,
appsec (14.418 s) : 14418000, 14418000
. : milestone, 14418000,
iast (18.182 s) : 18182000, 18182000
. : milestone, 18182000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
section candidate
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (14.693 s) : 14693000, 14693000
. : milestone, 14693000,
iast (18.233 s) : 18233000, 18233000
. : milestone, 18233000,
iast_GLOBAL (17.873 s) : 17873000, 17873000
. : milestone, 17873000,
profiling (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
tracing (14.559 s) : 14559000, 14559000
. : milestone, 14559000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~72ca095c4a, baseline=1.59.0-SNAPSHOT~34b16160f8
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.707 ms) : 3487, 3927
. : milestone, 3707,
iast (2.217 ms) : 2152, 2282
. : milestone, 2217,
iast_GLOBAL (2.261 ms) : 2195, 2327
. : milestone, 2261,
profiling (2.092 ms) : 2037, 2146
. : milestone, 2092,
tracing (2.05 ms) : 1998, 2102
. : milestone, 2050,
section candidate
no_agent (1.479 ms) : 1467, 1491
. : milestone, 1479,
appsec (3.744 ms) : 3523, 3965
. : milestone, 3744,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.256 ms) : 2191, 2322
. : milestone, 2256,
profiling (2.069 ms) : 2016, 2122
. : milestone, 2069,
tracing (2.039 ms) : 1987, 2090
. : milestone, 2039,
|
0a00af8 to
13f9715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: do not merge
Do not merge changes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]