Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 17, 2025

What does this PR do?

Migrates tracer to using Config.ciVisibilityEnabled instead of its local ciVisibilityEnabled

Motivation

Go Config Revamp

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Copy link
Contributor Author

mtoffl01 commented Dec 17, 2025

@mtoffl01 mtoffl01 marked this pull request as ready for review December 17, 2025 21:37
@mtoffl01 mtoffl01 requested review from a team as code owners December 17, 2025 21:37
@mtoffl01 mtoffl01 requested review from genesor and removed request for a team December 17, 2025 21:37
@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2025

Benchmarks

Benchmark execution time: 2025-12-19 16:31:26

Comparing candidate commit 931a6c9 in PR branch 12-17-migrate_civisibilityenabled with baseline commit 5d9df19 in branch 12-17-migrate_servicename.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.44%. Comparing base (5d9df19) to head (931a6c9).

Files with missing lines Patch % Lines
internal/config/config.go 10.00% 9 Missing ⚠️
ddtrace/tracer/tracer.go 0.00% 0 Missing and 2 partials ⚠️
ddtrace/tracer/option.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
ddtrace/tracer/stats.go 98.46% <100.00%> (ø)
ddtrace/tracer/option.go 83.74% <0.00%> (+0.13%) ⬆️
ddtrace/tracer/tracer.go 86.40% <0.00%> (ø)
internal/config/config.go 16.91% <10.00%> (+0.39%) ⬆️

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 931a6c9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@mtoffl01 mtoffl01 force-pushed the 12-17-migrate_civisibilityenabled branch from c38262f to ff183ec Compare December 18, 2025 16:56
@mtoffl01 mtoffl01 force-pushed the 12-17-migrate_civisibilityenabled branch from ff183ec to 931a6c9 Compare December 19, 2025 15:20
@mtoffl01 mtoffl01 force-pushed the 12-17-migrate_servicename branch from 515a4a5 to 5d9df19 Compare December 19, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants