Merged
Conversation
also allowed to properly extract trace context
astuyve
reviewed
Aug 7, 2023
astuyve
reviewed
Aug 7, 2023
astuyve
reviewed
Aug 7, 2023
astuyve
approved these changes
Aug 7, 2023
Contributor
astuyve
left a comment
astuyve
left a comment
There was a problem hiding this comment.
Couple notes, but functionally this looks good!
duncanista
deleted the
jordan.gonzalez/SLS-3938/inferred-spans/propagate-context-on-eventbridge-triggers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for tracing payloads.
Motivation
It's possible to have distributed tracing on it, so why not?
Testing Guidelines
Added unit tests.
Also tested manually.
Additional Notes
Since EventBridge doesn't provide resolution in milliseconds, we end up with really large spans for it.
Maybe this can be fixed by adding a new field. Research is still needed for this.
Types of Changes
Check all that apply