fix: Ensure authorized span headers are injected as str#325
Merged
joeyzhao2018 merged 1 commit intoDataDog:mainfrom Apr 25, 2023
Merged
fix: Ensure authorized span headers are injected as str#325joeyzhao2018 merged 1 commit intoDataDog:mainfrom
str#325joeyzhao2018 merged 1 commit intoDataDog:mainfrom
Conversation
The python3.7 runtime cannot serialize byte strings
Contributor
joeyzhao2018
left a comment
There was a problem hiding this comment.
Putting request changes here to block. We had to use encoding because
Injecting extra data to the original response can break invocations using cached authorization data. Symptoms: The first (authorizing) invocation succeeded. But the following requests received Internal Server Error messages.
Therefore, TODO on our side: we need to test the encode and decode case here. We should add the case to the the integration test.
Hi @Wesitos, could you please open an issue on the serialization problem mentioned in the description here so that we can have more information? Thank you in advance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It injects the authorizer span headers as a regular string instead of a byte string.
Motivation
The Python 3.7 lambda runtime can't serialize responses that contain byte strings.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply