Some env variables depend on DD_TRACE_ENABLED#323
Merged
joeyzhao2018 merged 2 commits intomainfrom Apr 25, 2023
Merged
Conversation
astuyve
approved these changes
Apr 14, 2023
Contributor
astuyve
left a comment
There was a problem hiding this comment.
I like the refactor of depends_on_dd_tracing_enabled here!
171c17d to
a854f59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make some env variables depend on
DD_TRACE_ENABLED, i.e. all False ifDD_TRACE_ENABLEDset to False:DD_COLD_START_TRACINGfor cold start aws.lambda.import spansDD_TRACE_MANAGED_SERVICESfor inferred spansDD_DECODE_AUTHORIZER_CONTEXTandDD_ENCODE_AUTHORIZER_CONTEXTfor lambda authorizor spans (a special case for inferred spans)Motivation
The features controlled by these env variables are all part of DD Tracing...
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply