Conversation
Contributor
|
Integration tests done:
from ddtrace.vendor.psutil import _psutil_linux
print(dir(_psutil_linux))
from ddtrace.vendor.wrapt import _wrappers
print(dir(_wrappers))
import ddtrace.sourcecode.setuptools_auto
import setuptools
print(setuptools.__spec__) # this will have origin='/var/lang/lib/python3.<X>/site-packages/setuptools/__init__.py'
print(setuptools.find_packages(where='mypkg', include=['pkg*'],))this proves that 1. already installed extension modules in ddtrace still work even we removed the setuptools that we used to install ddtrace. 2. when user importing setuptools, it's using the runtime's setuptools anyway. Based on those testings, this PR is safe to merge |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
setuptools contains binaries for every major architecture, but it's already included in the lambda runtime, so we don't need it.
I found this by pulling the python base images and running an interpreter, finding that
setuptoolsis resolved just fine:TODO - need to verify that the provided version doesn't conflict with our own, need to verify that dd-trace-py source code integration still works with this stripped. But integration tests pass and that's a very good sign.
Should save us 3mb.
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply