Repository navigation
test(platforms): run admin-auth assertions without driver, drop dead helper - #2992
Merged
Merged
Conversation
joeharris76
enabled auto-merge (squash)
October 14, 2026 20:48
joeharris76
marked this pull request as draft
October 15, 2026 12:33
auto-merge was automatically disabled
October 15, 2026 12:33
Pull request was converted to draft
joeharris76
marked this pull request as ready for review
October 15, 2026 12:36
joeharris76
enabled auto-merge (squash)
October 15, 2026 12:37
joeharris76
disabled auto-merge
October 15, 2026 13:20
joeharris76
marked this pull request as draft
October 15, 2026 13:20
…helper Move the snowflake importorskip in test_create_admin_connection below the user/no-username assertions so the admin-connection user-key fix is checked even when the driver is absent; only the DEFAULT_CONFIGURATION subset check still needs the driver. Delete the Snowflake _get_connection_params helper, which has no production caller, and repoint its three tests at the live _connect_params builder, including a real warehouse assertion in place of the tautology.
joeharris76
force-pushed
the
fix/snowflake-test-smalls
branch
from
October 15, 2026 19:47
6728473 to
817d874
Compare
joeharris76
marked this pull request as ready for review
October 15, 2026 19:49
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the snowflake importorskip in test_create_admin_connection below
the user/no-username assertions so the admin-connection user-key fix
is checked even when the driver is absent; only the
DEFAULT_CONFIGURATION subset check still needs the driver. Delete the
Snowflake _get_connection_params helper, which has no production caller,
and repoint its three tests at the live _connect_params builder,
including a real warehouse assertion in place of the tautology.