feat(ci): require external review for soundness paths - #2444
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](/s/com/githubusercontent/avatars/G.https/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3f3e5ce83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joeharris76
added this pull request to the merge queue
Sep 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 29, 2026
GitHub documents the function as toJson; the allowlist only had toJSON, so the new ci.yml merge-group usage failed the guard. Accept both casings.
The soundness-flag step crashed with 'Cannot iterate over null' when the merge_group event carried no pull_requests payload, failing the tooling check for every queue group and bouncing grouped PRs. Fall back to validating the merged tree directly when the payload is absent.
When the merge_group payload carries no pull_requests list, derive the anchor PR from the gh-readonly-queue branch name, verify its head is an ancestor of the group HEAD via the API, validate the anchor member, then validate the full base-to-head group diff so soundness paths elsewhere in the group cannot slip through.
joeharris76
force-pushed
the
fix/dev-loop-v2-soundness-hold
branch
from
September 29, 2026 11:44
4936484 to
6f14c93
Compare
joeharris76
added this pull request to the merge queue
Sep 29, 2026
The queue squashes the anchor PR onto the group base, so the anchor head is never an ancestor of the group HEAD. The ancestry check failed every queued soundness-path PR. Compare each anchor-changed file byte-for-byte between the anchor head and the group HEAD instead.
joeharris76
removed this pull request from the merge queue due to a manual request
Sep 29, 2026
joeharris76
enabled auto-merge
September 29, 2026 13:12
joeharris76
added this pull request to the merge queue
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolingto the documented required merge-queue status contract.Soundness review:
External reviewer: codex
Review output: #2444 (comment)
All Critical/High findings resolved.
Validation