Skip to content

feat(testing): enforce measured test tiers and quarantine metadata - #2443

Merged
joeharris76 merged 3 commits into
developfrom
fix/dev-loop-v2-duration-tiering
Sep 29, 2026
Merged

joeharris76 merged 3 commits into
developfrom
fix/dev-loop-v2-duration-tiering

Conversation

@joeharris76

@joeharris76 joeharris76 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add a schema-versioned per-test p95 duration artifact and a refresh utility for T3 JUnit reports.
  • Enforce explicit T1, T2, and T3 selection across Make targets and nightly jobs.
  • Fail collection for invalid or expired quarantine and duration-exemption metadata.
  • Enforce the 0.5 second T1 budget for measured fast tests without an exemption.
  • Run quarantined tests in T3 while skipping them in T1 and T2.
  • Replace workflow-lane assertions in tests/unit/test_marker_strategy.py with tier policy coverage.
  • Document the tier, marker, and duration artifact contract.

Validation

  • uv run ruff check .
  • uv run ruff format --check .
  • uv run ty check tests/duration_policy.py _project/scripts/update_test_durations.py
  • Focused duration and marker tests: 18 passed
  • T3 duration policy tests: 6 passed
  • Fast test collection: passed
  • make docs-validate: passed
  • YAML parse validation and make -n tier command inspection: passed

The full local make pr-preflight run reached the existing broad suite but failed on 61 unrelated repository baseline, preflight, UAT, and native-environment tests. The known macOS chdb cwd drift is tracked separately in PR #2441.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73f94fcbf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/duration_policy.py Outdated
Comment thread tests/duration_policy.py
Comment thread .github/workflows/nightly.yml
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T20:53:37.847582Z 73f94fc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@joeharris76
joeharris76 added this pull request to the merge queue Sep 28, 2026
@joeharris76
joeharris76 removed this pull request from the merge queue due to a manual request Sep 29, 2026
The duration-tier change added quarantine and duration_exempt markers to
pytest.ini but not pytest-ci.ini, so the broad local CI profile assertion
that both files register the same marker set failed in the merge queue's
medium-test job.

Register both markers in pytest-ci.ini with the same descriptions.
@joeharris76
joeharris76 force-pushed the fix/dev-loop-v2-duration-tiering branch from 70bde4e to c3130b1 Compare September 29, 2026 11:36
@joeharris76
joeharris76 added this pull request to the merge queue Sep 29, 2026
Merged via the queue into develop with commit a1b9c9b Sep 29, 2026
44 checks passed
@joeharris76
joeharris76 deleted the fix/dev-loop-v2-duration-tiering branch September 29, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant