-
Notifications
You must be signed in to change notification settings - Fork 0
docs: close cross-surface residual wording, scope, and release posture #2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeharris76
wants to merge
3
commits into
develop
Choose a base branch
from
fix/df-parity-residual-closeout
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
df59d66
docs: close cross-surface residual wording, scope, and release posture
joeharris76 5ee2180
docs: enumerate dual-surface benchmarks excluded from cross-surface g…
joeharris76 d46ab43
Merge remote-tracking branch 'origin/develop' into fix/df-parity-resi…
joeharris76 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
_project/decisions/cross-surface-scope-and-release-posture-2026-09-27.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Cross-surface scope boundary and release-branch posture | ||
|
|
||
| Date: 2026-09-27 | ||
|
|
||
| Status: Accepted. | ||
|
|
||
| ## Scope boundary | ||
|
|
||
| Cross-surface gates (`benchbox/core/equivalence/cross_surface.py`, `GATES`) | ||
| cover benchmarks that ship both a SQL surface and a static `QueryRegistry` | ||
| DataFrame surface. That is transcription and regression verification against | ||
| DuckDB SQL references at a bounded equivalence scale: the two surfaces are | ||
| authored from the same understanding by the same person, so the gate catches | ||
| transcription drift, not shared conceptual errors, and its signal holds only | ||
| at the gated scale (see the module docstring and | ||
| `_project/analysis/cross-surface-oracle-independence.md` for per-benchmark | ||
| provenance). | ||
|
|
||
| Out of scope for the cross-surface gate, by construction: | ||
|
|
||
| - Operation-pipeline benchmarks with no DataFrame query surface route to the | ||
| w2 fallback oracle (differential second-engine check or curated | ||
| expected-results subset), not to a cross-surface builder: | ||
| `write_primitives`, `metadata_primitives`, `transaction_primitives`, | ||
| `tpcdi` (see `_project/analysis/cross-surface-applicability.md`). | ||
| - Dual-surface benchmarks that have a SQL surface plus a DataFrame query | ||
| registry but are not currently gated, per | ||
| `_project/analysis/cross-surface-applicability.md`: `joinorder` and | ||
| `nyctaxi` are not cheaply gateable (bounded-scale rejection, canonical | ||
| manifest fetch, or downloader-backed network fetch); `tpch_skew` and | ||
| `tsbs_devops` have unverified SQL-to-DataFrame ID mappings (zero verbatim | ||
| ID overlap, mapping must be confirmed independently, never guessed); | ||
| `tpcds_obt` has an abandoned correspondence (OBT-native Q1..Q17 versus | ||
| TPC-DS numbered SQL IDs, ruled out without renumbering one side). These | ||
| stay outside `GATES` until their named precondition is met; the | ||
| `joinorder_synthetic` CI-enforced gate covers scaled smoke-test data for | ||
| the JoinOrder family in the meantime. | ||
| - `ai_primitives` and `vector_search` stay `supports_dataframe: false` in | ||
| `benchmark_registry.yaml` and are likewise single-surface benchmarks | ||
| needing a fallback oracle, not cross-surface members. | ||
|
|
||
| Building the w2 fallback oracle itself is explicitly out of scope here; this | ||
| record only routes the benchmarks to it so they are not silently unguarded. | ||
|
|
||
| ## Release-branch posture | ||
|
|
||
| `test.yml` runs only the bounded `test-correctness-gate` on release-bound | ||
| pull requests; the per-benchmark cross-surface suite runs in `pr.yml` on | ||
| `develop`. Release PRs therefore rely on develop-time squash-merge | ||
| enforcement: every change entering `develop` passes the blocking | ||
| correctness-gate suite (including all `GATES` cross-surface reports) before | ||
| it can ride a release. Adding the cross-surface suite to `test.yml` is a | ||
| separate, explicitly approved CI change if it is ever wanted; until then, | ||
| release coverage is by inheritance, not by omission. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.