Repository navigation
feat(benchmarks): promote vector_search to stable with integrity spec - #2394
Merged
Merged
Conversation
Add the missing BenchmarkSpec for vector_search (Q1-Q6, SF1 row counts for the vectors and vector_queries tables) and promote its registry support_status from beta to stable. The DataFrame routing decision is recorded as-is: supports_dataframe stays false (SQL-only). Updates the support-status matrix, contract-map counts, integrity coverage claims, and the drift-checked count pins.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](/s/com/githubusercontent/avatars/G.https/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8375bd8138
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Schema-v2 export normalizes producer query IDs Q1-Q6 to 1-6, while the integrity validator compares exported IDs directly against the spec set. The vector_search spec recorded the unnormalized Q1-Q6 form, so every complete run reported 0/6 expected queries and failed integrity validation. Record the normalized 1-6 IDs, matching how the TPC-H and TPC-DS specs already store their query IDs. Adds a regression test proving a complete vector_search export passes integrity validation.
joeharris76
added this pull request to the merge queue
Sep 26, 2026
… promotion - Validator counts skipped queries in count arithmetic and discounts compatibility skips from the success-rate floor, so version-gated skips such as StarRocks Q2 no longer fail runs. - Scope the support-status rationale honestly: Q5 measures the same brute-force kNN SQL as Q1 since no loader builds an HNSW index today. - Regression tests for the skipped-query paths.
joeharris76
removed this pull request from the merge queue due to a manual request
Sep 26, 2026
joeharris76
enabled auto-merge
September 27, 2026 13:59
joeharris76
added this pull request to the merge queue
Sep 27, 2026
joeharris76
removed this pull request from the merge queue due to a manual request
Sep 27, 2026
joeharris76
added this pull request to the merge queue
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 28, 2026
…stable-promotion # Conflicts: # docs/reference/public-contracts.md
Update platform metadata entries count from 50 to 52 and SQL-capable platforms from 46 to 48 in public-contracts.md to prevent contract drift.
joeharris76
enabled auto-merge
September 28, 2026 20:59
joeharris76
added this pull request to the merge queue
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing BenchmarkSpec for vector_search (Q1-Q6, SF1 row
counts for the vectors and vector_queries tables) and promote its
registry support_status from beta to stable. The DataFrame routing
decision is recorded as-is: supports_dataframe stays false (SQL-only).
Updates the support-status matrix, contract-map counts, integrity
coverage claims, and the drift-checked count pins.