Repository navigation
feat(joinorder): implement Track-2 sampled-from-real scaling strategy - #2386
Merged
Merged
Conversation
Lock in Option B per the 2026-07-04 decision: title-stratified downsampling of canonical IMDb-2013 with referential-integrity closure. Scale factor is the kept title fraction in (0, 1]; the keep predicate is deterministic (id mod denominator). Derived archives carry explicit joinorder_sampled identity, never canonical_imdb. Module separation keeps sampled logic out of the canonical path.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](/s/com/githubusercontent/avatars/G.https/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10cd43bb08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Require both movie_link endpoints to survive so neither title foreign key dangles. Close the retained title set over episode_of_id parents before filtering dependents. Validate the raw requested scale before limit_denominator rounding and reject sub-resolution values. Bind sampled manifests to the exact source archive via dataset version, manifest hash, and data archive hash.
ty rejected Container[int] (contains-only) where close_title_set_over episode parents iterates the kept titles. Collection keeps the membership contract and adds iteration.
joeharris76
added this pull request to the merge queue
Sep 26, 2026
…e, person subgraph Replace modulo-on-primary-key sampling with seeded-hash stratified selection uniform within (kind_id, production_year) strata, make episode-parent closure transitive over merged title and aka_title maps, charge episode clusters against the scale quota so the retained ratio tracks scale_factor, implement person-subgraph closure for aka_name and person_info over surviving cast persons, reject bool scale factors, and replace tautological test assertions with exact quota and proportionality checks.
joeharris76
removed this pull request from the merge queue due to a manual request
Sep 26, 2026
The two reader threads shared one sqlite3 connection with no execute synchronization. Concurrent executes on one such connection race at the driver level: observed locally as empty reads and as swallowed-execution failure dicts surfacing as fetchone() None on SELECT COUNT(*), and once in CI as a first-read zero. The shared tier guarantees overlapping stream lifetimes and close isolation, not lock-free concurrent executes on drivers without cursor-level thread safety, so the executes now take a lock while the barrier still forces both streams alive at once and the closes still run concurrently. Verified 25 consecutive local passes against a baseline that failed about 1 in 15.
joeharris76
enabled auto-merge
September 27, 2026 13:59
joeharris76
added this pull request to the merge queue
Sep 27, 2026
joeharris76
removed this pull request from the merge queue due to a manual request
Sep 27, 2026
joeharris76
added this pull request to the merge queue
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2026
joeharris76
added this pull request to the merge queue
Sep 28, 2026
joeharris76
removed this pull request from the merge queue due to the queue being cleared
Sep 28, 2026
joeharris76
added this pull request to the merge queue
Sep 28, 2026
joeharris76
removed this pull request from the merge queue due to the queue being cleared
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock in Option B per the 2026-07-04 decision: title-stratified
downsampling of canonical IMDb-2013 with referential-integrity
closure. Scale factor is the kept title fraction in (0, 1]; the keep
predicate is deterministic (id mod denominator). Derived archives
carry explicit joinorder_sampled identity, never canonical_imdb.
Module separation keeps sampled logic out of the canonical path.