Update DateTime to compile on Android - #6732
Merged
Merged
Conversation
Anton Kolesnyk (antkmsft)
marked this pull request as ready for review
September 11, 2025 21:33
Anton Kolesnyk (antkmsft)
requested review from
Larry Osterman (LarryOsterman) and
Rick Winter (RickWinter)
as code owners
September 11, 2025 21:33
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DateTime implementation to ensure compatibility with Android compilation by modifying static assertions and type handling in the GetMaxDateTime() function.
Key Changes
- Replaced strict type equality assertion with more flexible type property checks
- Changed from using
DateTime::clock::duration::repdirectly to usingstd::int64_tas the representative type - Added comprehensive static assertions to validate both system clock and DateTime clock duration properties
Larry Osterman (LarryOsterman)
approved these changes
Sep 11, 2025
Mohamed Zaki (mohamed-zaki-coding)
added a commit
to mohamed-zaki-coding/azure-sdk-for-cpp
that referenced
this pull request
Sep 24, 2026
Results from build 6876940 (26/31 jobs green): - macOS: current images link Homebrew's openssl@3 into /usr/local/include, so azure-core compiled against Homebrew's OpenSSL headers while linking vcpkg's OpenSSL 3.0.5 (57 -Wold-style-cast errors from /usr/local/include/openssl/safestack.h). Unlink the Homebrew formula on macOS before building. - macOS: the jump from Xcode 12.5.1 to 16.4 (Apple clang 17) surfaces new warnings in this branch's code, e.g. -Winteger-overflow in GetMaxDateTime() (datetime.cpp:54; fixed on main in Azure#6732). Build the macOS configurations with WARNINGS_AS_ERRORS=OFF; Linux and Windows keep warnings as errors. - Coverage on Ubuntu 22.04 is 92.28%, below the 93% line target; lower it to 91%, as main did when it moved to Ubuntu 22.04 (Azure#4442).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.