Skip to content

fix(studio): keep the reason of a failed Connect in the status - #802

Merged
pbertsch merged 6 commits into
mainfrom
fix/connect-reason
Nov 17, 2026
Merged

pbertsch merged 6 commits into
mainfrom
fix/connect-reason

Conversation

@pbertsch

Copy link
Copy Markdown
Member

Summary

A Connect to a device whose app was not running showed its reason in a toast and in the status for 2.5 seconds, then the status said "disconnected": a person who looked away saw no reason. The status now says connection failed: <first line of the reason> (the full text with its fix hint is the tooltip) until another device is picked or Connect is pressed again. The Wi-Fi connect form is unchanged.

Test plan

  • node test of the line (4 cases), wired into the Studio CI file and ci-local.
  • Playwright cf-01 (the reason is still there after 3.5 s; picking another device clears it) and cf-02; cf-01 fails with the old 2.5 s reset put back (checked).
  • Web suite 194 passed apart from two specs that are red on main until the spec-fix PR merges.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF

@pbertsch
pbertsch requested a review from a team as a code owner November 17, 2026 14:18
pbertsch and others added 4 commits November 17, 2026 08:57
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
…erseded attempt

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
@pbertsch
pbertsch merged commit 0c9cf0f into main Nov 17, 2026
11 of 12 checks passed
jay23606 added a commit to jay23606/flutter-probe that referenced this pull request Nov 17, 2026
…WaveSystems#802)

## Summary
A Connect to a device whose app was not running showed its reason in a toast and in the status for 2.5 seconds, then the status said "disconnected": a person who looked away saw no reason. The status now says `connection failed: <first line of the reason>` (the full text with its fix hint is the tooltip) until another device is picked or Connect is pressed again. The Wi-Fi connect form is unchanged.

## Test plan
- [x] node test of the line (4 cases), wired into the Studio CI file and ci-local.
- [x] Playwright cf-01 (the reason is still there after 3.5 s; picking another device clears it) and cf-02; cf-01 fails with the old 2.5 s reset put back (checked).
- [x] Web suite 194 passed apart from two specs that are red on main until the spec-fix PR merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant