Repository navigation
fix(studio): keep the reason of a failed Connect in the status - #802
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
…erseded attempt Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF
jay23606
added a commit
to jay23606/flutter-probe
that referenced
this pull request
Nov 17, 2026
…WaveSystems#802) ## Summary A Connect to a device whose app was not running showed its reason in a toast and in the status for 2.5 seconds, then the status said "disconnected": a person who looked away saw no reason. The status now says `connection failed: <first line of the reason>` (the full text with its fix hint is the tooltip) until another device is picked or Connect is pressed again. The Wi-Fi connect form is unchanged. ## Test plan - [x] node test of the line (4 cases), wired into the Studio CI file and ci-local. - [x] Playwright cf-01 (the reason is still there after 3.5 s; picking another device clears it) and cf-02; cf-01 fails with the old 2.5 s reset put back (checked). - [x] Web suite 194 passed apart from two specs that are red on main until the spec-fix PR merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Connect to a device whose app was not running showed its reason in a toast and in the status for 2.5 seconds, then the status said "disconnected": a person who looked away saw no reason. The status now says
connection failed: <first line of the reason>(the full text with its fix hint is the tooltip) until another device is picked or Connect is pressed again. The Wi-Fi connect form is unchanged.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01NxVy8Kr2nZk8HoMNcxZPFF